Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Uploading Custom Sound files not working, but showing success #27177

Merged
merged 1 commit into from
Nov 3, 2022
Merged

[FIX] Uploading Custom Sound files not working, but showing success #27177

merged 1 commit into from
Nov 3, 2022

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Nov 3, 2022 •
edited
Loading

Proposed changes (including videos or screenshots)

Issue(s)

Closes #26524

Steps to test or reproduce

Further comments

@dougfabris dougfabris marked this pull request as ready for review November 3, 2022 18:00
@pierre-lehnen-rc pierre-lehnen-rc changed the title [FIX] setTimeout call on uploadCustomSound [FIX] Uploading Custom Sound files not working, but showing success Nov 3, 2022
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Nov 3, 2022
@kodiakhq kodiakhq bot merged commit ec84cb6 into develop Nov 3, 2022
@kodiakhq kodiakhq bot deleted the chore/uploadCustomSound branch November 3, 2022 19:08
gabriellsh added a commit to Kartik18g/Rocket.Chat that referenced this pull request Nov 3, 2022
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into patch-9
9c72321 
* 'develop' of github.com:RocketChat/Rocket.Chat: (2462 commits)
  [FIX] Uploading Custom Sound files not working, but showing success (RocketChat#27177)
  Chore: Show better error logs (RocketChat#27156)
  [FIX] Message search breaking URL, usertags and emojis (RocketChat#20878)
  [NEW] REST API endpoint `/v1/oauth-apps.create` (RocketChat#27054)
  i18n: Language update from LingoHub 🤖 on 2022-10-31Z (RocketChat#27150)
  Chore: Convert client/views/directory/hooks to ts (RocketChat#26936)
  Chore: Convert client/views/directory/RoomTags to ts (RocketChat#26937)
  [FIX] UserCard not opening inside Threads (RocketChat#27096)
  [FIX] Gap between message content and message header when there's no text. (RocketChat#27165)
  Chore: docs grammar fix (RocketChat#26894)
  [FIX]  Removed mobile requirement for showing real name (RocketChat#26968)
  Chore: Cursor pointer to all the action buttons (RocketChat#24440)
  Chore: Bump actions/upload-artifact from 2 to 3 (RocketChat#27109)
  Chore: Enable PR Title Checker for forks (RocketChat#27144)
  Chore: Converting game center to typescript (RocketChat#26915)
  i18n: Language update from LingoHub 🤖 on 2022-10-24Z (RocketChat#27127)
  Chore: Add info log to remove all rooms method (RocketChat#27106)
  [IMPROVE] Quotes on E2EE Messages (RocketChat#26303)
  [NEW] REST API endpoint `/v1/rooms.delete` (RocketChat#26866)
  [FIX] Room Avatar being deleted after upload. (RocketChat#27060)
  ...
gabriellsh added a commit to im-adithya/Rocket.Chat that referenced this pull request Nov 3, 2022
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new-…
e86a350 
…password-change

* 'develop' of github.com:RocketChat/Rocket.Chat: (2885 commits)
  [FIX] Uploading Custom Sound files not working, but showing success (RocketChat#27177)
  Chore: Show better error logs (RocketChat#27156)
  [FIX] Message search breaking URL, usertags and emojis (RocketChat#20878)
  [NEW] REST API endpoint `/v1/oauth-apps.create` (RocketChat#27054)
  i18n: Language update from LingoHub 🤖 on 2022-10-31Z (RocketChat#27150)
  Chore: Convert client/views/directory/hooks to ts (RocketChat#26936)
  Chore: Convert client/views/directory/RoomTags to ts (RocketChat#26937)
  [FIX] UserCard not opening inside Threads (RocketChat#27096)
  [FIX] Gap between message content and message header when there's no text. (RocketChat#27165)
  Chore: docs grammar fix (RocketChat#26894)
  [FIX]  Removed mobile requirement for showing real name (RocketChat#26968)
  Chore: Cursor pointer to all the action buttons (RocketChat#24440)
  Chore: Bump actions/upload-artifact from 2 to 3 (RocketChat#27109)
  Chore: Enable PR Title Checker for forks (RocketChat#27144)
  Chore: Converting game center to typescript (RocketChat#26915)
  i18n: Language update from LingoHub 🤖 on 2022-10-24Z (RocketChat#27127)
  Chore: Add info log to remove all rooms method (RocketChat#27106)
  [IMPROVE] Quotes on E2EE Messages (RocketChat#26303)
  [NEW] REST API endpoint `/v1/rooms.delete` (RocketChat#26866)
  [FIX] Room Avatar being deleted after upload. (RocketChat#27060)
  ...
MartinSchoeler pushed a commit that referenced this pull request Nov 28, 2022
@dougfabris @MartinSchoeler
[FIX] Uploading Custom Sound files not working, but showing success (#…
94293a4 
…27177)
@ggazzo ggazzo mentioned this pull request Dec 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierre-lehnen-rc pierre-lehnen-rc pierre-lehnen-rc approved these changes

Assignees
No one assigned
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't play custom sound in 5.0.1-5.0.3 version [Error: Exception while invoking method uploadCustomSound]
3 participants
@dougfabris @pierre-lehnen-rc @ggazzo