Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Add button-icon-disabled-color to the palette #27522

Merged
merged 5 commits into from
Dec 13, 2022

Conversation

juliajforesti
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #27522 (5e374a4) into develop (3cf1c80) will increase coverage by 1.02%.
The diff coverage is n/a.

❗ Current head 5e374a4 differs from pull request most recent head d5fcd5e. Consider uploading reports for the commit d5fcd5e to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27522      +/-   ##
===========================================
+ Coverage    41.05%   42.07%   +1.02%     
===========================================
  Files          845      818      -27     
  Lines        18291    17772     -519     
  Branches      2078     2003      -75     
===========================================
- Hits          7509     7478      -31     
+ Misses       10510    10019     -491     
- Partials       272      275       +3     
Flag Coverage Δ
e2e 42.07% <ø> (+1.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo changed the title [FIX] Add button-icon-disabled-color to the palette Regression: Add button-icon-disabled-color to the palette Dec 13, 2022
@ggazzo ggazzo marked this pull request as ready for review December 13, 2022 01:00
@ggazzo ggazzo requested a review from a team as a code owner December 13, 2022 01:00
ggazzo
ggazzo previously approved these changes Dec 13, 2022
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Dec 13, 2022
@ggazzo ggazzo merged commit a0d46cd into develop Dec 13, 2022
@ggazzo ggazzo deleted the fix/sidebar-iconButton-disabled branch December 13, 2022 01:57
gabriellsh added a commit that referenced this pull request Dec 20, 2022
…/attachment-file

* 'develop' of github.com:RocketChat/Rocket.Chat: (33 commits)
  Chore: fix EmailInbox intermittent e2e tests (#27573)
  [IMPROVE] Authorize search of custom fields on `users.list` (#27423)
  Chore:  Threads as React components (#27524)
  [NEW] Upload service (#27543)
  [FIX] Fix emoji appearance on sidebar (#27580)
  [FIX] RoomLeader status not working (#27576)
  [FIX] Announcement banner link opening in the same page (#27554)
  Bump version to 5.4.1
  [FIX] Custom languages not being applied to i18next (#27557)
  [FIX] Registration and Login placeholders not being used (#27558)
  [FIX] Fix Login with Show default form disabled (#27475)
  [FIX] Message Actions menu does not close upon choosing an action (#27328)
  Chore: Deprecate unused omnichannel API (#27538)
  [FIX] Pagination not working on current chats (#27432)
  [FIX] Custom languages not being applied to i18next (#27557)
  [FIX] Registration and Login placeholders not being used (#27558)
  [FIX] Message Actions menu does not close upon choosing an action (#27328)
  Chore: Deprecate unused omnichannel API (#27538)
  Regression: Add button-icon-disabled-color to the palette (#27522)
  Chore: Refactor CreateChannelModal (#27469)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants