[FIX] Fix emoji appearance on sidebar #27580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ahmedibrahim404 <ahmedie20022011@gmail.com>
dionisio-bot
bot
added
stat: ready to merge
ggazzo
approved these changes
Dec 19, 2022
ggazzo
changed the title
gabriellsh
added a commit
that referenced
this pull request
Dec 20, 2022
…/attachment-file * 'develop' of github.com:RocketChat/Rocket.Chat: (33 commits) Chore: fix EmailInbox intermittent e2e tests (#27573) [IMPROVE] Authorize search of custom fields on `users.list` (#27423) Chore: Threads as React components (#27524) [NEW] Upload service (#27543) [FIX] Fix emoji appearance on sidebar (#27580) [FIX] RoomLeader status not working (#27576) [FIX] Announcement banner link opening in the same page (#27554) Bump version to 5.4.1 [FIX] Custom languages not being applied to i18next (#27557) [FIX] Registration and Login placeholders not being used (#27558) [FIX] Fix Login with Show default form disabled (#27475) [FIX] Message Actions menu does not close upon choosing an action (#27328) Chore: Deprecate unused omnichannel API (#27538) [FIX] Pagination not working on current chats (#27432) [FIX] Custom languages not being applied to i18next (#27557) [FIX] Registration and Login placeholders not being used (#27558) [FIX] Message Actions menu does not close upon choosing an action (#27328) Chore: Deprecate unused omnichannel API (#27538) Regression: Add button-icon-disabled-color to the palette (#27522) Chore: Refactor CreateChannelModal (#27469) ...
Merged
|
The PR description says that this closes #25106 “Text/Emoji Format in Sidebar & Emails” Thank you, @dougfabris and @sampaiodiego! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: ahmedibrahim404 ahmedie20022011@gmail.com
Proposed changes (including videos or screenshots)
The emojis appear in plain text format in the side-bar (As seen in the below issues)
By this PR, it should be fixed
This is how it looks now (As shown on the sidebar, it's appearing as an emoji not plaintext)
Issue(s)
Closes #25106
Steps to test or reproduce
Send any message containing an emoji via the chat, and look at the sidebar last message. It should now render as emoji not plain text.
Further comments