Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Carry query string on setting location #27742

Closed
wants to merge 2 commits into from

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

It fixes an issue of exiting the embedded layout on close a tab.

Issue(s)

Steps to test or reproduce

Further comments

@tassoevan tassoevan marked this pull request as ready for review January 12, 2023 19:23
@tassoevan tassoevan requested a review from a team as a code owner January 12, 2023 19:23
@dougfabris dougfabris self-assigned this Jan 12, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #27742 (15f063c) into develop (a50dfb4) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27742      +/-   ##
===========================================
- Coverage    43.02%   42.87%   -0.16%     
===========================================
  Files          818      818              
  Lines        17282    17282              
  Branches      1944     1944              
===========================================
- Hits          7436     7409      -27     
- Misses        9580     9610      +30     
+ Partials       266      263       -3     
Flag Coverage Δ
e2e 42.87% <0.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan changed the title Regression: Carry query string on setting location [FIX] Carry query string on setting location Jan 16, 2023
@tassoevan tassoevan added this to the 6.0.0 milestone Jan 24, 2023
@hugocostadev
Copy link
Contributor

Closed due to #27892

@hugocostadev hugocostadev removed this from the 6.0.0 milestone Jan 30, 2023
@tassoevan tassoevan deleted the regression/closing-tab-in-embedded-layout branch February 16, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants