-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Embedded layout opening sidebar #27892
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #27892 +/- ##
===========================================
- Coverage 42.09% 42.00% -0.10%
===========================================
Files 846 846
Lines 17545 17546 +1
Branches 2078 2078
===========================================
- Hits 7386 7370 -16
- Misses 9879 9897 +18
+ Partials 280 279 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
vitorekr
previously approved these changes
Jan 31, 2023
yash-rajpal
previously approved these changes
Feb 1, 2023
hugocostadev
dismissed stale reviews from yash-rajpal and vitorekr
via
February 6, 2023 19:03
55bcf6d
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: conflict
labels
Feb 6, 2023
yash-rajpal
approved these changes
Feb 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
In the embedded layout view, certain actions were opening the sidebar due to the missing query param mandatory to the embedded layout view (
?layout=embedded
)In addition to this issue, the user was able to navigate to different pages in the embedded layout causing them to get stuck on some other pages other than the Room page. Because of the reported issue, I removed some actions that redirect the user to other pages such as: "Reply in Direct Message"
Issue(s)
Steps to test or reproduce
?layout=embedded
to the URLFurther comments
TC-377