Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Embedded layout opening sidebar #27892

Merged
merged 4 commits into from
Feb 6, 2023
Merged

[FIX] Embedded layout opening sidebar #27892

merged 4 commits into from
Feb 6, 2023

Conversation

hugocostadev
Copy link
Contributor

@hugocostadev hugocostadev commented Jan 30, 2023

Proposed changes (including videos or screenshots)

In the embedded layout view, certain actions were opening the sidebar due to the missing query param mandatory to the embedded layout view (?layout=embedded)

In addition to this issue, the user was able to navigate to different pages in the embedded layout causing them to get stuck on some other pages other than the Room page. Because of the reported issue, I removed some actions that redirect the user to other pages such as: "Reply in Direct Message"

Issue(s)

Steps to test or reproduce

  1. Open the Rocket.Chat client
  2. Add the query string ?layout=embedded to the URL
  3. try to perform actions on the given screen that shows the sidebar

Further comments

TC-377

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #27892 (55bcf6d) into develop (15b76a0) will decrease coverage by 0.10%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27892      +/-   ##
===========================================
- Coverage    42.09%   42.00%   -0.10%     
===========================================
  Files          846      846              
  Lines        17545    17546       +1     
  Branches      2078     2078              
===========================================
- Hits          7386     7370      -16     
- Misses        9879     9897      +18     
+ Partials       280      279       -1     
Flag Coverage Δ
e2e 42.00% <50.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

vitorekr
vitorekr previously approved these changes Jan 31, 2023
yash-rajpal
yash-rajpal previously approved these changes Feb 1, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: conflict labels Feb 6, 2023
@kodiakhq kodiakhq bot merged commit e6279ad into develop Feb 6, 2023
@kodiakhq kodiakhq bot deleted the fix/embeded-layout branch February 6, 2023 20:24
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants