Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: When clicking on display option their checked status does not changes #27881

Merged
merged 4 commits into from
Mar 16, 2023

Conversation

AdityaSingh-02
Copy link
Contributor

@AdityaSingh-02 AdityaSingh-02 commented Jan 29, 2023

Proposed changes (including videos or screenshots)

This Pull request is Regarding Issue #27847 , When we were clicking on text Then checkboxes were not being checked . I have made Few changes and tested them and its working fine , I hava attached a video for reference..

record_000003.mp4

Issue(s)

Closes #27847

Steps to test or reproduce

Further comments

@AdityaSingh-02 AdityaSingh-02 requested a review from a team as a code owner January 29, 2023 06:52
@dougfabris dougfabris changed the title [IMPROVE] When clicking on display option their checked status does not changes #27847 [IMPROVE] When clicking on display option their checked status does not changes Mar 1, 2023
@AdityaSingh-02 AdityaSingh-02 changed the title [IMPROVE] When clicking on display option their checked status does not changes refactor: When clicking on display option their checked status does not changes Mar 16, 2023
@dougfabris dougfabris changed the title refactor: When clicking on display option their checked status does not changes fix: When clicking on display option their checked status does not changes Mar 16, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 16, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 16, 2023
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #27881 (7724e31) into develop (ac5ec7c) will increase coverage by 2.42%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27881      +/-   ##
===========================================
+ Coverage    42.65%   45.08%   +2.42%     
===========================================
  Files          742      755      +13     
  Lines        14527    14614      +87     
  Branches      2075     2093      +18     
===========================================
+ Hits          6197     6588     +391     
+ Misses        8040     7731     -309     
- Partials       290      295       +5     
Flag Coverage Δ
e2e 45.03% <ø> (+2.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit 5cd096f into RocketChat:develop Mar 16, 2023
@sampaiodiego sampaiodiego mentioned this pull request May 16, 2023
@AdityaSingh-02 AdityaSingh-02 deleted the UIUXclick branch May 30, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When clicking on display option their checked status does not changes
3 participants