fix: Gallery opening other image after closing #27957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #27957 +/- ##
===========================================
- Coverage 45.46% 45.27% -0.19%
===========================================
Files 760 760
Lines 14795 14802 +7
Branches 2086 2087 +1
===========================================
- Hits 6726 6702 -24
- Misses 7774 7806 +32
+ Partials 295 294 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
hugocostadev
approved these changes
Feb 14, 2023
dionisio-bot
bot
added
stat: ready to merge
sampaiodiego
removed
the
stat: ready to merge
hugocostadev
added
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
changed the title
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
sampaiodiego
pushed a commit
that referenced
this pull request
Mar 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
How to reproduce:
1 - Upload MANY images to a channel (they have to be images and the bigger and more images the easier to reproduce)
2 - Click on one of the images
3 - Try to close the glalery as QUICK as possible
If done correctly, another image will open after closing the gallery. You could also try opening different images or throttling the network thru the devtools in order to help reproduce it.
I also took some time to make part of the code more readable.
Issue(s)
Steps to test or reproduce
Further comments
TC-358