Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Fix Custom CSS #27993

Merged
merged 40 commits into from
Feb 23, 2023
Merged

Regression: Fix Custom CSS #27993

merged 40 commits into from
Feb 23, 2023

Conversation

juliajforesti
Copy link
Contributor

Reposition palette style tags before custom-css file in head to fix precedence override.

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #27993 (f545f76) into develop (7b756aa) will increase coverage by 1.11%.
The diff coverage is 39.24%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27993      +/-   ##
===========================================
+ Coverage    43.77%   44.88%   +1.11%     
===========================================
  Files          793      766      -27     
  Lines        15403    14903     -500     
  Branches      2142     2070      -72     
===========================================
- Hits          6742     6689      -53     
+ Misses        8370     7919     -451     
- Partials       291      295       +4     
Flag Coverage Δ
e2e 44.84% <39.24%> (+1.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review February 13, 2023 17:08
@juliajforesti juliajforesti marked this pull request as draft February 14, 2023 19:46
@juliajforesti juliajforesti marked this pull request as ready for review February 14, 2023 21:39
ggazzo
ggazzo previously approved these changes Feb 14, 2023
@juliajforesti juliajforesti requested a review from a team as a code owner February 15, 2023 18:41
@juliajforesti juliajforesti marked this pull request as draft February 16, 2023 21:39
dougfabris
dougfabris previously approved these changes Feb 23, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 23, 2023
@juliajforesti juliajforesti requested a review from a team as a code owner February 23, 2023 18:12
@ggazzo ggazzo merged commit 5f4d2ec into develop Feb 23, 2023
@ggazzo ggazzo deleted the chore/custom-css branch February 23, 2023 18:55
@ggazzo ggazzo changed the title Chore: Custom CSS Regression: Fix Custom CSS Feb 23, 2023
gabriellsh added a commit that referenced this pull request Feb 24, 2023
…jumpToMessage

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Fix RegisterForm Translations (#28156)
  Chore: e2e omnichannel tests - Close every opened page after the test (#28152)
  Chore: Remove fail-fast from matrix strategy (#28153)
  Chore: Fix houston metadata
  Regression: Fix improper usage of useEndpointData (#28050)
  Regression: View mode preferences without the selected option by default (#28120)
  Chore: Fix fetching Apps-Engine and MongoDB versions for release notes (#28129)
  Regression: Slash commands detected at any line (#28142)
  Regression: App requests notify admin function generating wrong link (#28111)
  Chore: Improve time of meteor build (#28128)
  Chore: Update tokens (#28079)
  Regression: Fix sidebar horizontal scrolling (#28125)
  Chore: Presence cap tweaks (#28058)
  Chore: Fix Services Docker Build
  Chore: Custom CSS  (#27993)
  Chore: Fix CI Docker Alpine build missing (#28138)
  Chore: Fix CI docker publish (#28134)
  Chore: Refactor CI to improve code reusability and organization (#28108)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants