Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: App requests notify admin function generating wrong link #28111

Merged
merged 4 commits into from
Feb 24, 2023

Conversation

rique223
Copy link
Contributor

@rique223 rique223 commented Feb 21, 2023

Proposed changes (including videos or screenshots)

Fixed a development oversight in which the link of the app request Rocket.Cat message was generated without the marketplace version of the app nor the requests tab param.
Demo gif (before):
notify-admin-before

Demo gif (after):
notify-admin-after

Issue(s)

Steps to test or reproduce

  1. Open marketplace as an end-user and make an app request;
  2. Switch to an admin account and click on Rocket.Cat in the home page sidebar;
  3. Click the learn more link of the app request notification;
  4. Click the requests tab of the app;

Further comments

Fixed a problem in the notify admins function, the marketplaceVersion of the requested app was missing which made the page not behave properly when navigating.
@rique223 rique223 requested review from a team as code owners February 21, 2023 13:59
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 21, 2023
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per previous definitions we'd consider this a regression, because it would be weird to show a "FIX" in the release notes for something that didn't exist before the release 😬

@rique223 rique223 changed the title [FIX] App requests notify admin function generating wrong link Regression: App requests notify admin function generating wrong link Feb 22, 2023
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #28111 (01c464d) into develop (497f2be) will decrease coverage by 2.24%.
The diff coverage is n/a.

❗ Current head 01c464d differs from pull request most recent head 2169487. Consider uploading reports for the commit 2169487 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28111      +/-   ##
===========================================
- Coverage    44.92%   42.69%   -2.24%     
===========================================
  Files          766      732      -34     
  Lines        14903    14321     -582     
  Branches      2070     2053      -17     
===========================================
- Hits          6695     6114     -581     
- Misses        7916     7935      +19     
+ Partials       292      272      -20     
Flag Coverage Δ
e2e 42.65% <ø> (-2.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego merged commit 88c4c9f into develop Feb 24, 2023
@sampaiodiego sampaiodiego deleted the fix/notify-admin-link branch February 24, 2023 00:15
gabriellsh added a commit that referenced this pull request Feb 24, 2023
…jumpToMessage

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Fix RegisterForm Translations (#28156)
  Chore: e2e omnichannel tests - Close every opened page after the test (#28152)
  Chore: Remove fail-fast from matrix strategy (#28153)
  Chore: Fix houston metadata
  Regression: Fix improper usage of useEndpointData (#28050)
  Regression: View mode preferences without the selected option by default (#28120)
  Chore: Fix fetching Apps-Engine and MongoDB versions for release notes (#28129)
  Regression: Slash commands detected at any line (#28142)
  Regression: App requests notify admin function generating wrong link (#28111)
  Chore: Improve time of meteor build (#28128)
  Chore: Update tokens (#28079)
  Regression: Fix sidebar horizontal scrolling (#28125)
  Chore: Presence cap tweaks (#28058)
  Chore: Fix Services Docker Build
  Chore: Custom CSS  (#27993)
  Chore: Fix CI Docker Alpine build missing (#28138)
  Chore: Fix CI docker publish (#28134)
  Chore: Refactor CI to improve code reusability and organization (#28108)
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: apps ecosystem AECO stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants