-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: App requests notify admin function generating wrong link #28111
Conversation
Fixed a problem in the notify admins function, the marketplaceVersion of the requested app was missing which made the page not behave properly when navigating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per previous definitions we'd consider this a regression, because it would be weird to show a "FIX" in the release notes for something that didn't exist before the release 😬
Codecov Report
@@ Coverage Diff @@
## develop #28111 +/- ##
===========================================
- Coverage 44.92% 42.69% -2.24%
===========================================
Files 766 732 -34
Lines 14903 14321 -582
Branches 2070 2053 -17
===========================================
- Hits 6695 6114 -581
- Misses 7916 7935 +19
+ Partials 292 272 -20
Flags with carried forward coverage won't be shown. Click here to find out more. |
…jumpToMessage * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Fix RegisterForm Translations (#28156) Chore: e2e omnichannel tests - Close every opened page after the test (#28152) Chore: Remove fail-fast from matrix strategy (#28153) Chore: Fix houston metadata Regression: Fix improper usage of useEndpointData (#28050) Regression: View mode preferences without the selected option by default (#28120) Chore: Fix fetching Apps-Engine and MongoDB versions for release notes (#28129) Regression: Slash commands detected at any line (#28142) Regression: App requests notify admin function generating wrong link (#28111) Chore: Improve time of meteor build (#28128) Chore: Update tokens (#28079) Regression: Fix sidebar horizontal scrolling (#28125) Chore: Presence cap tweaks (#28058) Chore: Fix Services Docker Build Chore: Custom CSS (#27993) Chore: Fix CI Docker Alpine build missing (#28138) Chore: Fix CI docker publish (#28134) Chore: Refactor CI to improve code reusability and organization (#28108)
Proposed changes (including videos or screenshots)
Fixed a development oversight in which the link of the app request Rocket.Cat message was generated without the marketplace version of the app nor the requests tab param.
Demo gif (before):
Demo gif (after):
Issue(s)
Steps to test or reproduce
Further comments