Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Normal and multiline messages adding extra spaces upon copying/pasting #28187

Merged
merged 10 commits into from
Mar 10, 2023

Conversation

Educg550
Copy link
Contributor

Issue(s)

Multiple break lines were being added to messages when copied.

Steps to test or reproduce

  1. Send any text message on a channel
  2. Copy it by clicking on it 3 times (including all lines)
  3. Paste it elsewhere

Further comments

TC-479

@Educg550 Educg550 requested a review from a team as a code owner February 27, 2023 14:40
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #28187 (4c278ba) into develop (1159cb3) will increase coverage by 5.30%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28187      +/-   ##
===========================================
+ Coverage    38.87%   44.18%   +5.30%     
===========================================
  Files          692      749      +57     
  Lines        13722    14569     +847     
  Branches      2006     2070      +64     
===========================================
+ Hits          5335     6437    +1102     
+ Misses        8138     7859     -279     
- Partials       249      273      +24     
Flag Coverage Δ
e2e 44.14% <ø> (+5.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

hugocostadev
hugocostadev previously approved these changes Feb 27, 2023
@hugocostadev hugocostadev added this to the 6.1.0 milestone Feb 27, 2023
@Educg550 Educg550 added the stat: ready to merge PR tested and approved waiting for merge label Mar 8, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Mar 8, 2023
@hugocostadev hugocostadev added the stat: ready to merge PR tested and approved waiting for merge label Mar 10, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 10, 2023
@kodiakhq kodiakhq bot merged commit 5444bf5 into develop Mar 10, 2023
@kodiakhq kodiakhq bot deleted the tc-479 branch March 10, 2023 15:34
gabriellsh added a commit that referenced this pull request Mar 13, 2023
…ketChat/Rocket.Chat into matrixSearchTestBranch

* 'feat/federation-public-room-search-2' of github.com:RocketChat/Rocket.Chat: (42 commits)
  refactor: Replace `_.isObject` with `isObject` (#28376)
  fix: small tweaks
  chore: Remove old css (#28140)
  fix: Thread list not scrolling to bottom when sending a message. (#28346)
  refactor: Federation refactor towards services + file names improvement + E2E tests fixes (#28326)
  i18n: Language update from LingoHub 🤖 on 2023-03-10Z (#28365)
  refactor: Improve sidebar search list hook (#28328)
  Chore: Change the PR title check to use conventional commits (#28358)
  [IMPROVE] Galician onboarding translation (#27908)
  [IMPROVE] Adding input type=password to AWS secrets fields (#28159)
  [FIX] Normal and multiline messages adding extra spaces upon copying/pasting (#28187)
  Chore: remove unused prop in register workspace modal (#28317)
  [FIX] App crashing when switching to Hindi (hi-In) language (#28285)
  [NEW] Registered Loom oEmbed (#28339)
  fix: create dm users before join the room
  tests: add unit tests + small tweaks
  fix: fix invite links button logic
  chore: fix lint
  Chore: Remove/replace some Meteor packages (#28189)
  Chore: Unused/dead code removal (#28155)
  ...
gabriellsh added a commit that referenced this pull request Mar 15, 2023
@casalsgh casalsgh removed this from the 6.1.0 milestone Apr 12, 2023
@casalsgh casalsgh added this to the 6.2.0 milestone Apr 12, 2023
@sampaiodiego sampaiodiego mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants