chore: Add rid to scope of create-invite-links permission check
#28241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28241 +/- ##
===========================================
+ Coverage 40.15% 42.75% +2.60%
===========================================
Files 737 745 +8
Lines 14463 14596 +133
Branches 2033 2056 +23
===========================================
+ Hits 5808 6241 +433
+ Misses 8380 8069 -311
- Partials 275 286 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
LucianoPierdona
changed the title
rid to scope of create-invite-links permission checkrid to scope of create-invite-links permission check
dionisio-bot
bot
added
the
stat: ready to merge
dougfabris
approved these changes
Mar 14, 2023
gabriellsh
added a commit
that referenced
this pull request
Mar 15, 2023
…avatarEmoji * 'develop' of github.com:RocketChat/Rocket.Chat: refactor: Types of Meteor methods (2/N) (#28424) fix: Fixed no role assign to manual registered users despite of Default Roles for Users settings (#28293) refactor: Types of Meteor methods (1/N) (#28420) fix: Emoji don't work after text in contiunous (#28216) chore: Add `rid` to scope of `create-invite-links` permission check (#28241) refactor(client): Move banner orchestration to `BannerRegion` effects (#28414) refactor: remove `Promise.await` calls from irc bridge (#28406)
sampaiodiego
pushed a commit
that referenced
this pull request
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR fixes a bug where users with the
ownerrole can't create invites because the button isn't being displayed for him, to solve this issue theridwas added to the scope of the check.Issue(s)
Closes #27570
Steps to test or reproduce
ownerhas privileges to create invites under admin permission settingsExpected Behavior
Actual Behavior
Further comments
TC-416