fix: Fixed no role assign to manual registered users despite of Default Roles for Users settings #28293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les for Users settings
|
@dudanogueira Can you please review this |
|
That is great! Thanks for your contribution! What do you think to add the prefilled field role with the default role? |
|
Yes @hugocostadev, I think that will be great. |
|
No @bhardwajdisha you can work on that, I only assign myself to keep track |
Codecov Report
@@ Coverage Diff @@
## develop #28293 +/- ##
===========================================
+ Coverage 45.06% 45.12% +0.05%
===========================================
Files 758 759 +1
Lines 14683 14688 +5
Branches 2074 2075 +1
===========================================
+ Hits 6617 6628 +11
+ Misses 7773 7767 -6
Partials 293 293
Flags with carried forward coverage won't be shown. Click here to find out more. |
…into issue#27736
bhardwajdisha
changed the title
…into issue#27736
|
Hi @hugocostadev , I have made the changes. |
ggazzo
approved these changes
Mar 15, 2023
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
hugocostadev
approved these changes
Mar 15, 2023
hugocostadev
added
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Mar 15, 2023
…avatarEmoji * 'develop' of github.com:RocketChat/Rocket.Chat: refactor: Types of Meteor methods (2/N) (#28424) fix: Fixed no role assign to manual registered users despite of Default Roles for Users settings (#28293) refactor: Types of Meteor methods (1/N) (#28420) fix: Emoji don't work after text in contiunous (#28216) chore: Add `rid` to scope of `create-invite-links` permission check (#28241) refactor(client): Move banner orchestration to `BannerRegion` effects (#28414) refactor: remove `Promise.await` calls from irc bridge (#28406)
sampaiodiego
pushed a commit
that referenced
this pull request
Apr 12, 2023
…lt Roles for Users settings (#28293)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Fixed no role assign to manual registered users despite of Default Roles for Users settings
changes done in apps/meteor/app/lib/server/functions/saveuser.js file and checked it on my local environment and it works fine. Please review this.
Rocket.chat.mp4
Issue(s)
closes #27736
Steps to test or reproduce
Further comments