Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrong error message when trying to create new team with existing team name #28270

Merged
merged 3 commits into from
Mar 13, 2023

Conversation

Bankar-Swapnil
Copy link
Contributor

@Bankar-Swapnil Bankar-Swapnil commented Mar 4, 2023

For solving this issue,
changes done in apps/meteor/client/sidebar/header/CreateTeam/CreateTeamModal.tsx file and checked it on my local environment and it works fine. Please review this.

Proposed changes (including videos or screenshots)

Screenshot (27)

Issue(s)

closes #28268

Steps to test or reproduce

  1. create first team with team name eg("test")
  2. try to create second team with team name same as first team eg("test")
  3. click on submit button now it shows correct error message

@Bankar-Swapnil Bankar-Swapnil requested a review from a team as a code owner March 4, 2023 05:54
@ggazzo ggazzo added this to the 6.1.0 milestone Mar 4, 2023
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you replace the message error above with Teams_Errors_team_name as well?

@Bankar-Swapnil
Copy link
Contributor Author

hello sir,
if we use the Teams_Errors_team_name message it shows an error message that ( You can't use "teamName" as a team name) but if we use Teams_Errors_Already_exists it shows a correct error message that (the team "teamName" already exists).

@dougfabris dougfabris changed the title [FIX] Wrong error message shows when trying to create new team with existing team name #28268 [FIX] Wrong error message shows when trying to create new team with existing team name Mar 6, 2023
@dougfabris dougfabris changed the title [FIX] Wrong error message shows when trying to create new team with existing team name fix: Wrong error message when trying to create new team with existing team name Mar 13, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 13, 2023
@kodiakhq kodiakhq bot merged commit 2b404b4 into RocketChat:develop Mar 13, 2023
@casalsgh casalsgh modified the milestones: 6.1.0, 6.2.0 Apr 12, 2023
@sampaiodiego sampaiodiego mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong error message shows when trying to create new team with existing team name
4 participants