Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Error message is displayed in case no file is found in custom sound section. #28302

Merged
merged 9 commits into from
Mar 15, 2023
Merged

fix: Error message is displayed in case no file is found in custom sound section. #28302

Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5948562
fixed issue: error message is displayed in case no file exist in cust…
bhardwajdisha Mar 6, 2023
c6fd085
Merge branch 'develop' into issue#28296
bhardwajdisha Mar 10, 2023
596d998
Merge branch 'develop' into issue#28296
bhardwajdisha Mar 10, 2023
020414d
removing comment
hugocostadev Mar 15, 2023
0d444c4
Merge branch 'develop' into issue#28296
kodiakhq[bot] Mar 15, 2023
1165155
Merge branch 'develop' into issue#28296
kodiakhq[bot] Mar 15, 2023
f40646f
Merge branch 'develop' into issue#28296
dougfabris Mar 15, 2023
2dd6aab
Merge branch 'develop' into issue#28296
kodiakhq[bot] Mar 15, 2023
0132bc4
Merge branch 'develop' into issue#28296
kodiakhq[bot] Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions apps/meteor/client/views/admin/customSounds/CustomSoundsRoute.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,6 @@ const CustomSoundsRoute = (): ReactElement => {
async () => {
const { sounds } = await getSounds(query);

if (sounds.length === 0) {
throw new Error(t('No_results_found'));
}
return sounds;
},
{
Expand Down Expand Up @@ -112,6 +109,7 @@ const CustomSoundsRoute = (): ReactElement => {
</Page.Header>
<Page.Content>
<>
<FilterByText onChange={({ text }): void => setParams(text)} />
{isLoading && (
<GenericTable>
<GenericTableHeader>{headers}</GenericTableHeader>
Expand All @@ -122,7 +120,6 @@ const CustomSoundsRoute = (): ReactElement => {
)}
{isSuccess && data && data.length > 0 && (
<>
<FilterByText onChange={({ text }): void => setParams(text)} />
<GenericTable>
<GenericTableHeader>{headers}</GenericTableHeader>
<GenericTableBody>
Expand Down