chore: ignore .eslintcache
#28475
Merged
chore: ignore .eslintcache
#28475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevLehman
force-pushed
the
chore/ignore-eslintcache
branch
from
48e94d6
to
d757907
Compare
dionisio-bot
bot
added
stat: ready to merge
Codecov Report
@@ Coverage Diff @@
## develop #28475 +/- ##
===========================================
- Coverage 45.05% 45.01% -0.05%
===========================================
Files 755 755
Lines 14614 14614
Branches 2094 2094
===========================================
- Hits 6585 6579 -6
- Misses 7730 7736 +6
Partials 299 299
Flags with carried forward coverage won't be shown. Click here to find out more. |
kodiakhq
bot
removed
the
stat: ready to merge
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
ggazzo
requested changes
Mar 23, 2023
|
I'd say because locally it does help to speed up the lint on subsequent runs. When committed is when it doesn't make sense as the file has the full paths for each file, which will change per machine |
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Mar 23, 2023
…ove/full-name-username * 'develop' of github.com:RocketChat/Rocket.Chat: (54 commits) chore: ignore `.eslintcache` (#28475) refactor: convert omnichannel callbacks to ts (#28564) refactor: Allow RoomCoordinator.roomFind to be async (#28566) refactor(models): Use Messages Raw model (4/N) (#28558) refactor(client): `meteor/session` usage (1/N) (#28565) refactor: Don't use meteor collections on migrations (#28563) feat: VideoConference Guest mode and Conference Router (#28186) refactor: promise.await removal 8/N (#28560) refactor: checkUsernameAvailability to async (#28557) refactor(promise.await): Low hanging fruits (2/2) (#28556) fix: Changing the app's error verification (#28450) refactor(promise.await): Low hanging fruits (1/N) (#28555) fix: Thread message preview (#28454) refactor: remove Promise.await from LDAP files (#28527) refactor: canAccessRoomId to async (#28540) refactor: Remove `LivechatInquiry` model (#28487) refactor(models): Use Messages Raw model (3/N) (#28549) refactor: remove Promise.await (#28539) chore: Make CI fail if checks fail (#28552) refactor: remove Promise.await from oauth manager (#28530) ...
gabriellsh
added a commit
that referenced
this pull request
Mar 23, 2023
…ixSearch * 'develop' of github.com:RocketChat/Rocket.Chat: (141 commits) ci(docker): use correct var name fix: Prevent blank space on live chat form validations (#28243) ci(docker): Push Docker tag for commit hash (#28578) fix: marketplace doc link wrong redirect (#28466) refactor: move `Subscriptions` 1x (#28531) chore: ignore `.eslintcache` (#28475) refactor: convert omnichannel callbacks to ts (#28564) refactor: Allow RoomCoordinator.roomFind to be async (#28566) refactor(models): Use Messages Raw model (4/N) (#28558) refactor(client): `meteor/session` usage (1/N) (#28565) refactor: Don't use meteor collections on migrations (#28563) feat: VideoConference Guest mode and Conference Router (#28186) refactor: promise.await removal 8/N (#28560) refactor: checkUsernameAvailability to async (#28557) refactor(promise.await): Low hanging fruits (2/2) (#28556) fix: Changing the app's error verification (#28450) refactor(promise.await): Low hanging fruits (1/N) (#28555) fix: Thread message preview (#28454) refactor: remove Promise.await from LDAP files (#28527) refactor: canAccessRoomId to async (#28540) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments