refactor: remove Promise.await #28539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28539 +/- ##
==========================================
Coverage ? 45.02%
==========================================
Files ? 755
Lines ? 14622
Branches ? 2108
==========================================
Hits ? 6584
Misses ? 7736
Partials ? 302
Flags with carried forward coverage won't be shown. Click here to find out more. |
rodrigok
approved these changes
Mar 22, 2023
gabriellsh
added a commit
that referenced
this pull request
Mar 23, 2023
…ove/full-name-username * 'develop' of github.com:RocketChat/Rocket.Chat: (54 commits) chore: ignore `.eslintcache` (#28475) refactor: convert omnichannel callbacks to ts (#28564) refactor: Allow RoomCoordinator.roomFind to be async (#28566) refactor(models): Use Messages Raw model (4/N) (#28558) refactor(client): `meteor/session` usage (1/N) (#28565) refactor: Don't use meteor collections on migrations (#28563) feat: VideoConference Guest mode and Conference Router (#28186) refactor: promise.await removal 8/N (#28560) refactor: checkUsernameAvailability to async (#28557) refactor(promise.await): Low hanging fruits (2/2) (#28556) fix: Changing the app's error verification (#28450) refactor(promise.await): Low hanging fruits (1/N) (#28555) fix: Thread message preview (#28454) refactor: remove Promise.await from LDAP files (#28527) refactor: canAccessRoomId to async (#28540) refactor: Remove `LivechatInquiry` model (#28487) refactor(models): Use Messages Raw model (3/N) (#28549) refactor: remove Promise.await (#28539) chore: Make CI fail if checks fail (#28552) refactor: remove Promise.await from oauth manager (#28530) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments