Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Types of Meteor methods (7/N) #28482

Merged
merged 4 commits into from
Mar 20, 2023
Merged

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Merging #28482 (961e28e) into develop (9c3b531) will decrease coverage by 0.09%.
The diff coverage is 31.57%.

❗ Current head 961e28e differs from pull request most recent head bd9bc93. Consider uploading reports for the commit bd9bc93 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28482      +/-   ##
===========================================
- Coverage    45.14%   45.05%   -0.09%     
===========================================
  Files          755      755              
  Lines        14614    14614              
  Branches      2094     2095       +1     
===========================================
- Hits          6597     6584      -13     
- Misses        7718     7734      +16     
+ Partials       299      296       -3     
Flag Coverage Δ
e2e 45.01% <31.57%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan marked this pull request as ready for review March 20, 2023 14:50
@tassoevan tassoevan requested review from a team as code owners March 20, 2023 14:50
@ggazzo ggazzo merged commit 94bdfa0 into develop Mar 20, 2023
@ggazzo ggazzo deleted the refactor/methods-types-7 branch March 20, 2023 16:18
gabriellsh added a commit that referenced this pull request Mar 21, 2023
…avatarEmoji

* 'develop' of github.com:RocketChat/Rocket.Chat: (40 commits)
  refactor(promise.await): saveUserIdentity.ts, saveUser.js, relinquishRoomOwnerships.ts and deleteMessage.ts (#28493)
  refactor: Remove `FederationRoomEvents` model (#28488)
  refactor: Promise.await removal (#28481)
  refactor: move from canDeleteMessage to canDeleteMessageAsync (#28480)
  refactor: move from canAccessRoom to canAccessRoomAsync (#28477)
  refactor: convert getRoomRoles to async (#28485)
  refactor: Remove `Promise.await` calls from Slack Adapter (#28408)
  chore: make callbacks accept async (#28486)
  fix: Horizontal scroll in main room if text is too long (#28434)
  refactor: Types of Meteor methods (7/N) (#28482)
  refactor: Models feature parity (#28456)
  refactor: Types of Meteor methods (5/N) (#28461)
  refactor: Types of Meteor methods (6/N) (#28478)
  refactor: Convert rooms endpoints to TS (#28448)
  refactor: Convert groups endpoints to typescript (#28432)
  refactor: Convert channels endpoints to TS (#28469)
  refactor: Convert chat endpoints to TS (#28417)
  chore: Remove invalid `aria-description` from list menus (#28471)
  fix: videoconf stream (#28455)
  Chore(deps): Bump supercharge/mongodb-github-action from 1.7.0 to 1.9.0 (#28003)
  ...
@casalsgh casalsgh modified the milestones: 6.1.0, 6.2.0 Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants