fix: Horizontal scroll in main room if text is too long #28434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28434 +/- ##
===========================================
- Coverage 45.12% 45.08% -0.04%
===========================================
Files 755 755
Lines 14614 14614
Branches 2093 2093
===========================================
- Hits 6594 6589 -5
- Misses 7722 7728 +6
+ Partials 298 297 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
gabriellsh
force-pushed
the
fix/horizontalScroll
branch
from
cd4ede5
to
1df2afb
Compare
hugocostadev
approved these changes
Mar 16, 2023
dionisio-bot
bot
added
the
stat: ready to merge
tiagoevanp
approved these changes
Mar 20, 2023
ggazzo
approved these changes
Mar 20, 2023
gabriellsh
added a commit
that referenced
this pull request
Mar 21, 2023
…avatarEmoji * 'develop' of github.com:RocketChat/Rocket.Chat: (40 commits) refactor(promise.await): saveUserIdentity.ts, saveUser.js, relinquishRoomOwnerships.ts and deleteMessage.ts (#28493) refactor: Remove `FederationRoomEvents` model (#28488) refactor: Promise.await removal (#28481) refactor: move from canDeleteMessage to canDeleteMessageAsync (#28480) refactor: move from canAccessRoom to canAccessRoomAsync (#28477) refactor: convert getRoomRoles to async (#28485) refactor: Remove `Promise.await` calls from Slack Adapter (#28408) chore: make callbacks accept async (#28486) fix: Horizontal scroll in main room if text is too long (#28434) refactor: Types of Meteor methods (7/N) (#28482) refactor: Models feature parity (#28456) refactor: Types of Meteor methods (5/N) (#28461) refactor: Types of Meteor methods (6/N) (#28478) refactor: Convert rooms endpoints to TS (#28448) refactor: Convert groups endpoints to typescript (#28432) refactor: Convert channels endpoints to TS (#28469) refactor: Convert chat endpoints to TS (#28417) chore: Remove invalid `aria-description` from list menus (#28471) fix: videoconf stream (#28455) Chore(deps): Bump supercharge/mongodb-github-action from 1.7.0 to 1.9.0 (#28003) ...
d-gubert
pushed a commit
that referenced
this pull request
Mar 22, 2023
Co-authored-by: Hugo Costa <hugocarreiracosta@gmail.com>
Closed
d-gubert
pushed a commit
that referenced
this pull request
Mar 23, 2023
Co-authored-by: Hugo Costa <hugocarreiracosta@gmail.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Removed inline styles from elements and substituted
ptag fordivFor a quick explanation, the
ptag adds the multiple line breaks by default when copying text. We should revise in the parser how we deal with paragraphs and text blocks.Issue(s)
Steps to test or reproduce
Send a big text without whitespaces. Ex:
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaLine won't break and screen will scroll horizontally.
Further comments
TC-540