refactor: Remove optional return of room coordinator #28592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28592 +/- ##
===========================================
+ Coverage 43.95% 45.00% +1.04%
===========================================
Files 743 753 +10
Lines 14448 14662 +214
Branches 2115 2129 +14
===========================================
+ Hits 6350 6598 +248
+ Misses 7810 7760 -50
- Partials 288 304 +16
Flags with carried forward coverage won't be shown. Click here to find out more. |
gabriellsh
added a commit
that referenced
this pull request
Mar 24, 2023
…nto fix/avatarEmoji * 'fix/avatarEmoji' of github.com:RocketChat/Rocket.Chat: (72 commits) refactor: `LivechatRooms` removal - 3 (#28506) fix: Livechat MessageList not auto scrolling on new message (#28547) chore: Add types for `Meteor.userAsync` (#28597) refactor: Easy replacements of Meteor.call to Meteor.callAsync (#28595) refactor: `Subscriptions` model - 2x (#28535) refactor: `LivechatRooms` 2 (#28504) regression: ldap sync not working (#28583) fix: Generic Table Search (#28401) refactor: Remove `Apps persistence` model (#28510) refactor(models): Use Messages Raw model (5/N) (#28590) refactor: federation promise.await methods 2/N (#28593) refactor: federation Promise.await 1/N (#28591) feat: Make the marketplace search bar placeholder dynamic (#28394) fix: Bring unseen app requests badge back and minor refactors (#28348) refactor: Remove `apps` & `app logs` models (#28509) refactor: Convert meteor call to callAsync (2/N) (#28588) refactor: Remove `Meteor.call` in favor of `Meteor.callAsync` - 1 (#28576) refactor: Restore removed function for counting on LivechatDepartmentAgents (#28577) refactor: Convert meteor call to callAsync (#28575) refactor: Remove optional return of room coordinator (#28592) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments