fix: Generic Table Search #28401
Merged
fix: Generic Table Search #28401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28401 +/- ##
===========================================
- Coverage 45.08% 44.57% -0.51%
===========================================
Files 753 734 -19
Lines 14662 14335 -327
Branches 2129 2122 -7
===========================================
- Hits 6610 6390 -220
+ Misses 7750 7638 -112
- Partials 302 307 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
previously requested changes
Mar 13, 2023
tassoevan
previously requested changes
Mar 13, 2023
ggazzo
reviewed
Mar 15, 2023
guijun13
previously approved these changes
Mar 17, 2023
guijun13
approved these changes
Mar 23, 2023
dionisio-bot
bot
added
the
stat: ready to merge
hugocostadev
dismissed stale reviews from tassoevan and ggazzo
Issues addressed
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Mar 24, 2023
…nto fix/avatarEmoji * 'fix/avatarEmoji' of github.com:RocketChat/Rocket.Chat: (72 commits) refactor: `LivechatRooms` removal - 3 (#28506) fix: Livechat MessageList not auto scrolling on new message (#28547) chore: Add types for `Meteor.userAsync` (#28597) refactor: Easy replacements of Meteor.call to Meteor.callAsync (#28595) refactor: `Subscriptions` model - 2x (#28535) refactor: `LivechatRooms` 2 (#28504) regression: ldap sync not working (#28583) fix: Generic Table Search (#28401) refactor: Remove `Apps persistence` model (#28510) refactor(models): Use Messages Raw model (5/N) (#28590) refactor: federation promise.await methods 2/N (#28593) refactor: federation Promise.await 1/N (#28591) feat: Make the marketplace search bar placeholder dynamic (#28394) fix: Bring unseen app requests badge back and minor refactors (#28348) refactor: Remove `apps` & `app logs` models (#28509) refactor: Convert meteor call to callAsync (2/N) (#28588) refactor: Remove `Meteor.call` in favor of `Meteor.callAsync` - 1 (#28576) refactor: Restore removed function for counting on LivechatDepartmentAgents (#28577) refactor: Convert meteor call to callAsync (#28575) refactor: Remove optional return of room coordinator (#28592) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
When the user changes the page and tries to search for a room that is not currently visible on the page it’s not returning any results. This is also reproducible in the Users table
Current Behavior:
It returns the list filtering by the name
Previous Behavior:
Not found - It was not finding the room because it’s filtering only in the current page
Issue(s)
Steps to test or reproduce
Further comments
TC-524
I also added the
refetchOnWindowFocus: false,to useQuery methods to avoid re-fetching data on user focus on the page, this avoid a lot requests