Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid throw error on settings.watch at startup #28649

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

KevLehman
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@KevLehman KevLehman marked this pull request as ready for review March 27, 2023 20:49
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 27, 2023
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #28649 (430bb2f) into develop (759fc54) will decrease coverage by 5.90%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28649      +/-   ##
===========================================
- Coverage    45.15%   39.25%   -5.90%     
===========================================
  Files          749      686      -63     
  Lines        14573    13604     -969     
  Branches      2246     2160      -86     
===========================================
- Hits          6580     5340    -1240     
- Misses        7689     7992     +303     
+ Partials       304      272      -32     
Flag Coverage Δ
e2e 39.22% <ø> (-5.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Mar 28, 2023
@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Mar 28, 2023
@kodiakhq kodiakhq bot merged commit 366b8e9 into develop Mar 28, 2023
@kodiakhq kodiakhq bot deleted the fix/settings-watch-error-on-startup branch March 28, 2023 16:58
@sampaiodiego sampaiodiego mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants