Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Leader Bar presence status alignment #28793

Merged
merged 4 commits into from
Apr 4, 2023
Merged

fix: Leader Bar presence status alignment #28793

merged 4 commits into from
Apr 4, 2023

Conversation

hugocostadev
Copy link
Contributor

@hugocostadev hugocostadev commented Apr 4, 2023

Proposed changes (including videos or screenshots)

Presence status must be aligned with the user name (Leader bar)

Previous:
image

Now:
image

Issue(s)

Steps to test or reproduce

Further comments

TC-552

@hugocostadev hugocostadev requested a review from a team as a code owner April 4, 2023 14:06
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #28793 (bb648d5) into develop (0460599) will increase coverage by 4.85%.
The diff coverage is n/a.

❗ Current head bb648d5 differs from pull request most recent head 9b9e17d. Consider uploading reports for the commit 9b9e17d to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28793      +/-   ##
===========================================
+ Coverage    40.53%   45.38%   +4.85%     
===========================================
  Files          708      726      +18     
  Lines        14071    14279     +208     
  Branches      2176     2213      +37     
===========================================
+ Hits          5703     6481     +778     
+ Misses        8077     7491     -586     
- Partials       291      307      +16     
Flag Coverage Δ
e2e 45.34% <ø> (+4.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

guijun13
guijun13 previously approved these changes Apr 4, 2023
@hugocostadev hugocostadev added the stat: ready to merge PR tested and approved waiting for merge label Apr 4, 2023
@ggazzo ggazzo merged commit 38e23d9 into develop Apr 4, 2023
@ggazzo ggazzo deleted the fix/leader-bar branch April 4, 2023 18:33
@sampaiodiego sampaiodiego mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants