fix: Single omni closed room can't be deleted when the user doesn't have the permission to 'remove all closed omni rooms' #28877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix when an user tries to remove a single room when the user doesn't have the permission to remove all closed omnichannel rooms
KevLehman
approved these changes
Apr 12, 2023
KevLehman
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #28877 +/- ##
===========================================
+ Coverage 44.50% 45.67% +1.16%
===========================================
Files 719 728 +9
Lines 13884 14088 +204
Branches 2179 2193 +14
===========================================
+ Hits 6179 6434 +255
+ Misses 7412 7345 -67
- Partials 293 309 +16
Flags with carried forward coverage won't be shown. Click here to find out more. |
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
MartinSchoeler
added
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
remove_room.mp4
Issue(s)
SUP-188
When an user doesn't have the permission 'remove-closed-livechat-rooms' it blocks to delete a single closed omni room.
Steps to test or reproduce
Disable the permission 'remove-closed-livechat-rooms' and try to remove one omni closed room.
Further comments