Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): Small UI bugs #28893

Merged
merged 3 commits into from
Apr 12, 2023
Merged

fix(client): Small UI bugs #28893

merged 3 commits into from
Apr 12, 2023

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

It fixes an insidious bug affecting the focus of the message composer whenever the user start typing. It also reverts some refactored code that affected desktop app users (e.g. cut/copy/paste not working).

Issue(s)

Steps to test or reproduce

Further comments

@tassoevan tassoevan added this to the 6.2.0 milestone Apr 12, 2023
@tassoevan tassoevan requested a review from a team as a code owner April 12, 2023 20:00
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #28893 (9c3d0ce) into develop (07798bb) will decrease coverage by 0.09%.
The diff coverage is 90.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28893      +/-   ##
===========================================
- Coverage    45.36%   45.28%   -0.09%     
===========================================
  Files          729      729              
  Lines        14173    14179       +6     
  Branches      2190     2188       -2     
===========================================
- Hits          6430     6421       -9     
- Misses        7434     7452      +18     
+ Partials       309      306       -3     
Flag Coverage Δ
e2e 45.24% <90.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 12, 2023
Copy link
Contributor

@jeanfbrito jeanfbrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 12, 2023
@kodiakhq kodiakhq bot merged commit da20773 into develop Apr 12, 2023
@kodiakhq kodiakhq bot deleted the fix/small-ui-bugs branch April 12, 2023 23:29
@sampaiodiego sampaiodiego mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants