Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ComposerPopupPreview trespassing the composer limit #28896

Merged
merged 9 commits into from
Apr 14, 2023

Conversation

dougfabris
Copy link
Member

Proposed changes (including videos or screenshots)

before

image

image

after

image

image

Issue(s)

Steps to test or reproduce

Further comments

@dougfabris dougfabris added this to the 6.2.0 milestone Apr 13, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #28896 (1c1ee41) into develop (14d2419) will decrease coverage by 2.39%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28896      +/-   ##
===========================================
- Coverage    45.74%   43.36%   -2.39%     
===========================================
  Files          728      696      -32     
  Lines        14088    13526     -562     
  Branches      2193     2177      -16     
===========================================
- Hits          6444     5865     -579     
- Misses        7331     7366      +35     
+ Partials       313      295      -18     
Flag Coverage Δ
e2e 43.31% <ø> (-2.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@hugocostadev hugocostadev linked an issue Apr 13, 2023 that may be closed by this pull request
tassoevan
tassoevan previously approved these changes Apr 13, 2023
Copy link
Contributor

@tassoevan tassoevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 20rem?

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Apr 13, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 13, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Apr 13, 2023
@dougfabris dougfabris added the stat: ready to merge PR tested and approved waiting for merge label Apr 14, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 14, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 14, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 14, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 14, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 14, 2023
@kodiakhq kodiakhq bot merged commit 778024e into develop Apr 14, 2023
@kodiakhq kodiakhq bot deleted the fix/composer-popup-preview branch April 14, 2023 21:35
@sampaiodiego sampaiodiego mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Username suggestion list misaligned
2 participants