fix: Fixing the user status change by app #28965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagoevanp
previously approved these changes
Apr 18, 2023
d-gubert
requested changes
Apr 18, 2023
Codecov Report
@@ Coverage Diff @@
## release-6.2.0 #28965 +/- ##
=================================================
- Coverage 46.13% 46.04% -0.09%
=================================================
Files 728 728
Lines 14088 14088
Branches 2193 2193
=================================================
- Hits 6499 6487 -12
- Misses 7277 7289 +12
Partials 312 312
Flags with carried forward coverage won't be shown. Click here to find out more. |
AllanPazRibeiro
force-pushed
the
AECO-15-the-user-status-is-not-been-reactive-changing-by-app
branch
from
fcba247
to
553f860
Compare
…-reactive-changing-by-app
sampaiodiego
approved these changes
Apr 20, 2023
d-gubert
approved these changes
Apr 20, 2023
d-gubert
deleted the
AECO-15-the-user-status-is-not-been-reactive-changing-by-app
branch
tassoevan
pushed a commit
that referenced
this pull request
Apr 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Fixing a bug in the app bridge where the user prop was not being considered on the user reactive change regarding the user status.
Issue(s)
The app bridge was not correctly handling changes to the user status when the user prop was updated. This led to inconsistencies in the app's UI, where the user status would not be properly reflected in certain cases.
To fix this issue, I updated the app bridge to properly consider changes to the user prop when handling user status changes. This ensures that the app's UI accurately reflects the user's current status at all times.
Steps to test or reproduce
Basically, you only need to create a simple app that changes the user status and status text by any trigger. Now the user status will change instantly.
Further comments