fix: Removed agent access to already taken rooms #28979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28979 +/- ##
===========================================
+ Coverage 45.98% 46.76% +0.78%
===========================================
Files 685 698 +13
Lines 12988 13076 +88
Branches 2209 2227 +18
===========================================
+ Hits 5972 6115 +143
+ Misses 6705 6645 -60
- Partials 311 316 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
tassoevan
previously approved these changes
Apr 20, 2023
KevLehman
previously approved these changes
Apr 20, 2023
|
Forget it, got my answer 😬 |
dionisio-bot
bot
added
stat: ready to merge
MartinSchoeler
previously approved these changes
May 8, 2023
dionisio-bot
bot
added
stat: ready to merge
ggazzo
requested changes
May 15, 2023
kodiakhq
bot
removed
the
stat: ready to merge
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
🦋 Changeset detectedLatest commit: 994271f The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
ggazzo
approved these changes
Jun 5, 2023
This was referenced Jun 5, 2023
aleksandernsilva
added a commit
that referenced
this pull request
Jun 6, 2023
Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat>
gabriellsh
added a commit
that referenced
this pull request
Jun 6, 2023
…importer-messages-not-shown * 'develop' of github.com:RocketChat/Rocket.Chat: fix: Room history scroll position (#29335) fix: check for $addToSet to be not empty before passing update params (#29378) chore: update `badge-level-0` color (#29460) fix: Saving Business hour throws an alert (#29449) regression: emojiPicker position (#29408) chore: Update codeowners to add ownership of rest typings package to backend (#29437) fix: Removed agent access to already taken rooms (#28979) fix: `queuedForUser` endpoint not filtering by status (#29189) regression: Marketplace Selectors (#29443) chore: fix contextualbar size (#29441) chore: `ComposerBoxPopup` Items alignment (#29320) feat: add support for `MONOLITH_TRANSPORTER` env var (#29373) fix: Import progress page stuck at 0% (#29421) feat: access-marketplace permission (#29203) chore(ddp-client): freeze data emitted by the sdk (#29430) refactor: `Table` on Integrations Page (#29428) regression: Update `LoadingIndicator` colors (#29424) chore(meteor): Update mention style (#29426)
This was referenced Jun 9, 2023
This was referenced Jun 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR fixes an issue where an agent can see another agent's conversation with "manual" routing method.
Issue(s)
OC-680
OC-873
Steps to test or reproduce
Further comments