Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Update LoadingIndicator colors #29424

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Jun 1, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

DSAR-171

@dougfabris dougfabris requested a review from a team as a code owner June 1, 2023 17:10
@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2023

⚠️ No Changeset found

Latest commit: 5dbe9c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jun 1, 2023
@dougfabris dougfabris added this to the 6.3.0 milestone Jun 1, 2023
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #29424 (5dbe9c8) into develop (88b8a95) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29424      +/-   ##
===========================================
+ Coverage    46.62%   46.64%   +0.02%     
===========================================
  Files          698      698              
  Lines        13075    13075              
  Branches      2227     2227              
===========================================
+ Hits          6096     6099       +3     
+ Misses        6660     6656       -4     
- Partials       319      320       +1     
Flag Coverage Δ
e2e 46.60% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo merged commit 4e91e59 into develop Jun 1, 2023
@ggazzo ggazzo deleted the regression/loading-colors branch June 1, 2023 20:23
gabriellsh added a commit that referenced this pull request Jun 6, 2023
…importer-messages-not-shown

* 'develop' of github.com:RocketChat/Rocket.Chat:
  fix: Room history scroll position (#29335)
  fix: check for $addToSet to be not empty before passing update params (#29378)
  chore: update `badge-level-0` color (#29460)
  fix: Saving Business hour throws an alert (#29449)
  regression: emojiPicker position (#29408)
  chore: Update codeowners to add ownership of rest typings package to backend (#29437)
  fix: Removed agent access to already taken rooms (#28979)
  fix: `queuedForUser` endpoint not filtering by status (#29189)
  regression: Marketplace Selectors (#29443)
  chore: fix contextualbar size (#29441)
  chore: `ComposerBoxPopup` Items alignment (#29320)
  feat: add support for `MONOLITH_TRANSPORTER` env var (#29373)
  fix: Import progress page stuck at 0% (#29421)
  feat: access-marketplace permission (#29203)
  chore(ddp-client): freeze data emitted by the sdk (#29430)
  refactor: `Table` on Integrations Page (#29428)
  regression: Update `LoadingIndicator` colors (#29424)
  chore(meteor): Update mention style (#29426)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants