Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Marketplace): Scroll to the top of the marketplace apps list when page changed #29095

Merged
merged 2 commits into from
May 17, 2023

Conversation

tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Apr 28, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

AECO-128

@tiagoevanp tiagoevanp requested a review from a team as a code owner April 28, 2023 19:37
@tiagoevanp tiagoevanp added this to the 6.2.0 milestone Apr 28, 2023
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #29095 (f8a1c72) into develop (abe5fb5) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29095      +/-   ##
===========================================
- Coverage    46.81%   46.74%   -0.07%     
===========================================
  Files          705      705              
  Lines        13221    13221              
  Branches      2213     2213              
===========================================
- Hits          6189     6180       -9     
- Misses        6721     6729       +8     
- Partials       311      312       +1     
Flag Coverage Δ
e2e 46.70% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tiagoevanp tiagoevanp modified the milestones: 6.2.0, 6.0.3, 6.3.0 Apr 29, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 17, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels May 17, 2023
@kodiakhq kodiakhq bot merged commit 722f0b5 into develop May 17, 2023
@kodiakhq kodiakhq bot deleted the feat/scroll-top-marketplace-list branch May 17, 2023 18:58
gabriellsh added a commit that referenced this pull request May 18, 2023
…ove/mentions

* 'develop' of github.com:RocketChat/Rocket.Chat:
  chore: skip hook if HUSKY env var is set to 0 (#29283)
  ci: skip husky hooks on ci (#29279)
  chore: Add `roomName` on Composer placeholder (#29255)
  regression: fix console warnings (#29277)
  ci: fix Release Task
  chore: Add Changesets (#29275)
  feat(Marketplace): Scroll to the top of the marketplace apps list when page changed (#29095)
  fix: Members/Channels list infinite scroll (#28636)
gabriellsh added a commit that referenced this pull request May 23, 2023
…memberList

* 'develop' of github.com:RocketChat/Rocket.Chat: (72 commits)
  fix: respect useEmoji pref on messages (#28975)
  chore: Move 2fa challenge handler to rest api package (#29263)
  refactor(integrations): Replace Fibers dependency by Deasync (#29081)
  chore: improve server stream typings (#29128)
  fix: Livechat `CSP` whitelist validation (#29278)
  chore: `ListItem` stories (#29251)
  regression(push): fix error when adding headers to send push notification (#29287)
  fix: Handle login services errors (#28795)
  chore: skip hook if HUSKY env var is set to 0 (#29283)
  ci: skip husky hooks on ci (#29279)
  chore: Add `roomName` on Composer placeholder (#29255)
  regression: fix console warnings (#29277)
  ci: fix Release Task
  chore: Add Changesets (#29275)
  feat(Marketplace): Scroll to the top of the marketplace apps list when page changed (#29095)
  fix: Members/Channels list infinite scroll (#28636)
  test: use local httpbin container on github CI's (#29067)
  Bump vm2 version 3.9.19 (#29258)
  i18n: Language update from LingoHub 🤖 on 2023-05-16Z (#29252)
  chore: Composer missing scrollbar color (#29256)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants