fix: Livechat CSP whitelist validation
#29278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 509e797 The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
KevLehman
changed the title
CSP whitelist validation
KevLehman
previously approved these changes
May 17, 2023
MartinSchoeler
previously approved these changes
May 17, 2023
Codecov Report
@@ Coverage Diff @@
## develop #29278 +/- ##
============================================
+ Coverage 30.92% 46.84% +15.92%
============================================
Files 575 707 +132
Lines 10825 13234 +2409
Branches 1976 2217 +241
============================================
+ Hits 3348 6200 +2852
+ Misses 7268 6720 -548
- Partials 209 314 +105
Flags with carried forward coverage won't be shown. Click here to find out more. |
kodiakhq
bot
dismissed stale reviews from MartinSchoeler and KevLehman
via
a325b23
ggazzo
approved these changes
May 18, 2023
KevLehman
approved these changes
May 18, 2023
dionisio-bot
bot
added
stat: ready to merge
aleksandernsilva
removed
the
stat: ready to merge
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
This was referenced May 18, 2023
sampaiodiego
pushed a commit
that referenced
this pull request
May 19, 2023
Merged
This was referenced May 20, 2023
gabriellsh
added a commit
that referenced
this pull request
May 23, 2023
…memberList * 'develop' of github.com:RocketChat/Rocket.Chat: (72 commits) fix: respect useEmoji pref on messages (#28975) chore: Move 2fa challenge handler to rest api package (#29263) refactor(integrations): Replace Fibers dependency by Deasync (#29081) chore: improve server stream typings (#29128) fix: Livechat `CSP` whitelist validation (#29278) chore: `ListItem` stories (#29251) regression(push): fix error when adding headers to send push notification (#29287) fix: Handle login services errors (#28795) chore: skip hook if HUSKY env var is set to 0 (#29283) ci: skip husky hooks on ci (#29279) chore: Add `roomName` on Composer placeholder (#29255) regression: fix console warnings (#29277) ci: fix Release Task chore: Add Changesets (#29275) feat(Marketplace): Scroll to the top of the marketplace apps list when page changed (#29095) fix: Members/Channels list infinite scroll (#28636) test: use local httpbin container on github CI's (#29067) Bump vm2 version 3.9.19 (#29258) i18n: Language update from LingoHub 🤖 on 2023-05-16Z (#29252) chore: Composer missing scrollbar color (#29256) ...
This was referenced May 25, 2023
This was referenced Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR fixes the Livechat CSP validation, which was incorrectly blocking access to the widget for all non whitelisted domains.
Issue(s)
SUP-235
Steps to test or reproduce
Further comments