Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: create i18n package #29097

Merged
merged 10 commits into from
May 4, 2023
Merged

refactor: create i18n package #29097

merged 10 commits into from
May 4, 2023

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Apr 28, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #29097 (864b1d3) into develop (8dbf241) will decrease coverage by 0.13%.
The diff coverage is 38.46%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29097      +/-   ##
===========================================
- Coverage    47.01%   46.89%   -0.13%     
===========================================
  Files          711      709       -2     
  Lines        13256    13207      -49     
  Branches      2204     2195       -9     
===========================================
- Hits          6232     6193      -39     
+ Misses        6709     6704       -5     
+ Partials       315      310       -5     
Flag Coverage Δ
e2e 46.86% <38.46%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

MarcosSpessatto
MarcosSpessatto previously approved these changes May 2, 2023
@ggazzo ggazzo marked this pull request as ready for review May 3, 2023 21:01
@ggazzo ggazzo requested review from a team as code owners May 3, 2023 21:01
@ggazzo ggazzo changed the title chore: create i18n package refactor: create i18n package May 3, 2023
KevLehman
KevLehman previously approved these changes May 3, 2023
packages/i18n/src/index.mjs Show resolved Hide resolved
packages/i18n/src/locales Show resolved Hide resolved
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the language selection in "My Account" is not working as before:

before:
image

now:
image

the same for the Language setting on Admin:
image

they are also missing the "Default" value.

some weird behavior, after I change my preferred language on My Account, it doesn't translate everything without a refresh.. but it changes the language for some strings.

@ggazzo
Copy link
Member Author

ggazzo commented May 4, 2023

some weird behavior, after I change my preferred language on My Account, it doesn't translate everything without a refresh.. but it changes the language for some strings.

it should be solved by now ;)

@ggazzo
Copy link
Member Author

ggazzo commented May 4, 2023

WHERE IS MY APPROVAL @sampaiodiego ❤️ ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants