-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: create i18n package #29097
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #29097 +/- ##
===========================================
- Coverage 47.01% 46.89% -0.13%
===========================================
Files 711 709 -2
Lines 13256 13207 -49
Branches 2204 2195 -9
===========================================
- Hits 6232 6193 -39
+ Misses 6709 6704 -5
+ Partials 315 310 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
…patible ones (#29122) Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like the language selection in "My Account" is not working as before:
the same for the Language setting on Admin:
they are also missing the "Default" value.
some weird behavior, after I change my preferred language on My Account, it doesn't translate everything without a refresh.. but it changes the language for some strings.
it should be solved by now ;) |
WHERE IS MY APPROVAL @sampaiodiego ❤️ ? |
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments