fix: Custom translations do not work

[matheusbsilva137]

Proposed changes (including videos or screenshots)

Issue(s)

Introduced in #29097

Steps to test or reproduce

Further comments

TC-953

[changeset-bot]

🦋 Changeset detected

Latest commit: 0ff52d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

Merging #30383 (0ff52d8) into release-6.4.0 (b46b7ee) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           release-6.4.0   #30383      +/-   ##
=================================================
- Coverage          50.09%   50.04%   -0.05%     
=================================================
  Files                775      775              
  Lines              14491    14491              
  Branches            2618     2618              
=================================================
- Hits                7259     7252       -7     
- Misses              6825     6829       +4     
- Partials             407      410       +3     

Flag	Coverage Δ
e2e	48.45% <ø> (-0.06%)	⬇️
unit	60.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[tassoevan]

Is ignoring the prefix (instead of assuming it's core) a good idea? Also, what about server-side translations?

[yash-rajpal]

Is ignoring the prefix (instead of assuming it's core) a good idea? Also, what about server-side translations?

The final results object doesn't contain the namespace prefix for any of the translations, we remove the namespace prefix before adding it to the final translations object. In this case it wasn't working for custom-translations not having namespace prefix so this fix handles that case.