Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: emoji popup trigger length #29282

Merged
merged 11 commits into from
Jun 7, 2023
Merged

chore: emoji popup trigger length #29282

merged 11 commits into from
Jun 7, 2023

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented May 18, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Closes #28844

Steps to test or reproduce

Further comments

TC-617

@changeset-bot
Copy link

changeset-bot bot commented May 18, 2023

🦋 Changeset detected

Latest commit: 3a98000

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yash-rajpal yash-rajpal changed the title implement emoji popup trigger length chore: implement emoji popup trigger length May 18, 2023
@yash-rajpal yash-rajpal changed the title chore: implement emoji popup trigger length chore: emoji popup trigger length May 19, 2023
@dougfabris dougfabris marked this pull request as ready for review May 30, 2023 16:50
@dougfabris dougfabris requested a review from a team as a code owner May 30, 2023 16:50
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #29282 (3a98000) into develop (90d310a) will decrease coverage by 1.05%.
The diff coverage is 50.92%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29282      +/-   ##
===========================================
- Coverage    46.88%   45.84%   -1.05%     
===========================================
  Files          729      686      -43     
  Lines        13880    12995     -885     
  Branches      2197     2211      +14     
===========================================
- Hits          6508     5957     -551     
+ Misses        7054     6725     -329     
+ Partials       318      313       -5     
Flag Coverage Δ
e2e 45.81% <50.92%> (-1.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 7, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 7, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 7, 2023
@kodiakhq kodiakhq bot merged commit 29556cb into develop Jun 7, 2023
@kodiakhq kodiakhq bot deleted the emoji-popup-triggerLength branch June 7, 2023 18:59
@scuciatto scuciatto added this to the 6.3.0 milestone Jun 8, 2023
gabriellsh added a commit that referenced this pull request Jun 12, 2023
…memberList

* 'develop' of github.com:RocketChat/Rocket.Chat: (43 commits)
  chore: Pages empty state consistency (#29439)
  refactor: Convert Omnichannel helper ee to ts (#29274)
  regression(i18n): Broken translations on client-side startup (#29442)
  chore: break down helpers.ts and create new files (#28611)
  test: runInBand unit test (#29484)
  i18n: system message copy updates (#29372)
  chore: emoji popup trigger length (#29282)
  fix: Seat counter including apps (#29489)
  fix: Invalid message draft (#29474)
  fix: message deletion fails if has files attached on filesystem storage (#29313)
  chore: replace meteor.call -> sdk.call (#29318)
  chore: deprecation api (#29347)
  fix: Imported messages are not displayed (#29416)
  chore: convert metrics to ts (#29475)
  chore: use new Livechat SDK Implementation (#29098)
  fix: Room history scroll position (#29335)
  fix: check for $addToSet to be not empty before passing update params (#29378)
  chore: update `badge-level-0` color (#29460)
  fix: Saving Business hour throws an alert (#29449)
  regression: emojiPicker position (#29408)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rocket.Chat turns :D into 🏴󠁧󠁢󠁥󠁮󠁧󠁿
6 participants