Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace meteor.call -> sdk.call #29318

Merged
merged 6 commits into from
Jun 6, 2023
Merged

chore: replace meteor.call -> sdk.call #29318

merged 6 commits into from
Jun 6, 2023

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented May 22, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented May 22, 2023

⚠️ No Changeset found

Latest commit: ab357d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo force-pushed the chore/sdk-calls branch 5 times, most recently from e0c07bc to b5f78bd Compare May 23, 2023 00:09
@ggazzo ggazzo marked this pull request as ready for review May 23, 2023 00:47
@ggazzo ggazzo requested review from a team as code owners May 23, 2023 00:47
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #29318 (ab357d6) into develop (1e1d10e) will increase coverage by 7.92%.
The diff coverage is 36.58%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29318      +/-   ##
===========================================
+ Coverage    38.01%   45.93%   +7.92%     
===========================================
  Files          648      685      +37     
  Lines        12479    12989     +510     
  Branches      2150     2208      +58     
===========================================
+ Hits          4744     5967    +1223     
+ Misses        7453     6712     -741     
- Partials       282      310      +28     
Flag Coverage Δ
e2e 45.90% <36.58%> (+7.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo requested a review from a team as a code owner June 6, 2023 19:10
@ggazzo ggazzo merged commit 5db4e1f into develop Jun 6, 2023
@ggazzo ggazzo deleted the chore/sdk-calls branch June 6, 2023 22:20
gabriellsh added a commit that referenced this pull request Jun 12, 2023
…memberList

* 'develop' of github.com:RocketChat/Rocket.Chat: (43 commits)
  chore: Pages empty state consistency (#29439)
  refactor: Convert Omnichannel helper ee to ts (#29274)
  regression(i18n): Broken translations on client-side startup (#29442)
  chore: break down helpers.ts and create new files (#28611)
  test: runInBand unit test (#29484)
  i18n: system message copy updates (#29372)
  chore: emoji popup trigger length (#29282)
  fix: Seat counter including apps (#29489)
  fix: Invalid message draft (#29474)
  fix: message deletion fails if has files attached on filesystem storage (#29313)
  chore: replace meteor.call -> sdk.call (#29318)
  chore: deprecation api (#29347)
  fix: Imported messages are not displayed (#29416)
  chore: convert metrics to ts (#29475)
  chore: use new Livechat SDK Implementation (#29098)
  fix: Room history scroll position (#29335)
  fix: check for $addToSet to be not empty before passing update params (#29378)
  chore: update `badge-level-0` color (#29460)
  fix: Saving Business hour throws an alert (#29449)
  regression: emojiPicker position (#29408)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants