Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Livechat Reactivity issues with createOrUpdateGuest (6.4.8 version) #30993

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Nov 16, 2023

@MartinSchoeler MartinSchoeler added this to the 6.4.7 milestone Nov 16, 2023
Copy link

changeset-bot bot commented Nov 16, 2023

⚠️ No Changeset found

Latest commit: 5213815

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #30993 (5213815) into release-6.4.8 (550900b) will increase coverage by 1.45%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.4.8   #30993      +/-   ##
=================================================
+ Coverage          44.74%   46.20%   +1.45%     
=================================================
  Files                730      767      +37     
  Lines              13954    14278     +324     
  Branches            2600     2624      +24     
=================================================
+ Hits                6244     6597     +353     
+ Misses              7314     7273      -41     
- Partials             396      408      +12     
Flag Coverage Δ
e2e 44.10% <ø> (+1.67%) ⬆️
unit 60.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler changed the base branch from 6.4.7 to release-6.4.7 November 16, 2023 19:27
@MartinSchoeler MartinSchoeler marked this pull request as ready for review November 17, 2023 12:44
@MartinSchoeler MartinSchoeler requested review from a team as code owners November 17, 2023 12:44
Base automatically changed from release-6.4.7 to master November 17, 2023 18:28
@MartinSchoeler MartinSchoeler changed the title fix: Livechat Reactivity issues with createOrUpdateGuest (6.4.7 version) fix: Livechat Reactivity issues with createOrUpdateGuest (6.4.8 version) Nov 20, 2023
@MartinSchoeler MartinSchoeler modified the milestones: 6.4.7, 6.4.8 Nov 20, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Nov 20, 2023
@MartinSchoeler MartinSchoeler changed the base branch from master to release-6.4.8 November 20, 2023 14:34
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Nov 20, 2023
@kodiakhq kodiakhq bot merged commit a1c7f5c into release-6.4.8 Nov 20, 2023
43 of 44 checks passed
@kodiakhq kodiakhq bot deleted the fix-livechat-api branch November 20, 2023 16:55
kodiakhq bot pushed a commit that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants