fix(livechat): registering guest multiple times cause message loss #32069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 287f17d The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ggazzo
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32069 +/- ##
========================================
Coverage 54.80% 54.81%
========================================
Files 2299 2299
Lines 50793 50793
Branches 10394 10394
========================================
+ Hits 27839 27844 +5
+ Misses 20456 20448 -8
- Partials 2498 2501 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
force-pushed
the
fix/register-guest
branch
from
a92e42f to
13b5f37
Compare
MartinSchoeler
previously approved these changes
Mar 28, 2024
ggazzo
force-pushed
the
fix/register-guest
branch
from
fa2a29c to
27d0582
Compare
ggazzo
force-pushed
the
fix/register-guest
branch
from
27d0582 to
8256028
Compare
MartinSchoeler
approved these changes
Mar 29, 2024
dionisio-bot
bot
added
stat: ready to merge
ggazzo
force-pushed
the
fix/register-guest
branch
from
5416b54 to
6cf4688
Compare
ggazzo
force-pushed
the
fix/register-guest
branch
from
6cf4688 to
287f17d
Compare
dionisio-bot
bot
added
the
stat: ready to merge
ggazzo
added a commit
that referenced
this pull request
Apr 3, 2024
Merged
gabriellsh
added a commit
that referenced
this pull request
Apr 4, 2024
* develop: (71 commits) fix: search room not reactive after room name changes (#32123) test: fix `should edit name of targetChannel` flaky test (#32121) fix: UI allowing to mark room as favorite despite room was not a `default` room (#32063) chore: Remove duplicated `ChannelDeletionTable` (#32114) test(livechat): fix Department flaky test (#32102) test(livechat): File upload settings (#32060) test: contact center after hook calling wrong endpoint (#32094) fix(livechat): registering guest multiple times cause message loss (#32069) test: allow csp for livechat tests (#32116) chore: Move portals to the portals folder (#32090) test: `InitialData.insertAdminUserFromEnv` (#32066) fix: `CSP` error right after `setInlineScriptsAllowed` (#32108) chore: Create/Edit room consistency (#31960) chore: Remove references to EE code from the app events (#31926) test(Livechat): Clean up after registerGuest() test (#32092) test: make presence api tests fully independent (#31782) test: make roles fully independent (#31783) chore: bump version to 7.0.0-develop test: make login api tests fully independent (#31786) fix!: api login should not suggest which credential is wrong (#32086) ...
gabriellsh
added a commit
that referenced
this pull request
Apr 4, 2024
* origin: refactor: `TeamsChannels` to typescript (#32109) fix: search room not reactive after room name changes (#32123) test: fix `should edit name of targetChannel` flaky test (#32121) fix: UI allowing to mark room as favorite despite room was not a `default` room (#32063) chore: Remove duplicated `ChannelDeletionTable` (#32114) test(livechat): fix Department flaky test (#32102) test(livechat): File upload settings (#32060) test: contact center after hook calling wrong endpoint (#32094) fix(livechat): registering guest multiple times cause message loss (#32069) test: allow csp for livechat tests (#32116) chore: Move portals to the portals folder (#32090) test: `InitialData.insertAdminUserFromEnv` (#32066) fix: `CSP` error right after `setInlineScriptsAllowed` (#32108)
|
/backport 6.6.7 |
|
Sorry, I couldn't do that backport because of conflicts. Could you please solve them? you can do so by running the following commands: after that just run |
ggazzo
added a commit
that referenced
this pull request
Apr 23, 2024
|
/backport 6.6.7 |
|
Pull request #32300 added to Project: "Patch 6.6.7" |
Merged
ggazzo
added a commit
that referenced
this pull request
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduced here:
#30993
When calling the method of register/setToken, when the value is the same, it loads the configs again (with the list of empty messages). As the room and department were the same, the application did not react to the change.
Now whenever a "sensitive" value changes, it will load the config and then the list of messages.
Proposed changes (including videos or screenshots)
Issue(s)
closes #32042
Steps to test or reproduce
Further comments
https://rocketchat.atlassian.net/browse/SUP-526