Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: handle rocket.cat creation and deletion #31170

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Dec 6, 2023

https://rocketchat.atlassian.net/browse/SUP-417

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Dec 6, 2023

⚠️ No Changeset found

Latest commit: 7ee7f83

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6f48470) 49.33% compared to head (7ee7f83) 49.55%.
Report is 56 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31170      +/-   ##
===========================================
+ Coverage    49.33%   49.55%   +0.21%     
===========================================
  Files         3307     3309       +2     
  Lines        81265    81417     +152     
  Branches     16649    16701      +52     
===========================================
+ Hits         40094    40344     +250     
+ Misses       36472    36375      -97     
+ Partials      4699     4698       -1     
Flag Coverage Δ
e2e 53.16% <ø> (+0.67%) ⬆️
e2e-api 40.66% <83.33%> (-0.01%) ⬇️
unit 76.51% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review December 28, 2023 21:25
@ggazzo ggazzo requested a review from a team as a code owner December 28, 2023 21:25
@ggazzo ggazzo added this to the 6.6 milestone Jan 12, 2024
Co-authored-by: Kevin Aleman <kaleman960@gmail.com>
@ggazzo ggazzo merged commit 30183fd into develop Jan 23, 2024
43 checks passed
@ggazzo ggazzo deleted the chore/handle-rocket.cat-creation branch January 23, 2024 00:08
gabriellsh added a commit that referenced this pull request Jan 23, 2024
* 'develop' of github.com:RocketChat/Rocket.Chat: (143 commits)
  fix: Marketplace apps installed as private showing as installed (#31514)
  test: fix messaging flaky test (#31512)
  fix: change the push sound sent when the push is from video conference (#30910)
  fix: ensure sessionId on Sessions documents (#31487)
  chore: handle rocket.cat creation and deletion (#31170)
  chore(agenda): Changes in Agenda API (#31427)
  refactor: Pay the debt of some TODO comments (#30338)
  feat: Room header keyboard navigability (#31516)
  fix: Cron job for clearing OEmbed cache isn't working (#31336)
  refactor(client): Handling of custom statuses (#31500)
  fix: Prevent `Fallback forward departments` feature to go on loop when configured as circular chain (#31328)
  feat: Add `push.test` endpoint (#31289)
  chore: split UserProvider into two: User and Authentication (#31513)
  fix: Can't remove channel's password to join (#31507)
  chore: convert CAS integration code to typescript (#31492)
  feat: Composer keyboard navigability (#31510)
  fix: Render warning in Logs - (MessageType.render is deprecated. Use MessageType.message instead) (#31426)
  feat: Convert emoji shortname to unicode on notification emails. (#31225)
  chore: Normalize `ButtonGroup` (#31499)
  chore: improve type definitions for login service configurations (#31491)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants