-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Cron job for clearing OEmbed cache isn't working #31336
Conversation
🦋 Changeset detectedLatest commit: 4625e37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #31336 +/- ##
========================================
Coverage 49.56% 49.57%
========================================
Files 3318 3315 -3
Lines 81542 81505 -37
Branches 16750 16742 -8
========================================
- Hits 40416 40403 -13
+ Misses 36419 36401 -18
+ Partials 4707 4701 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
…nto fix/oembed-clear-cache
apps/meteor/client/views/admin/settings/inputs/ActionSettingInput.tsx
Outdated
Show resolved
Hide resolved
* 'develop' of github.com:RocketChat/Rocket.Chat: (143 commits) fix: Marketplace apps installed as private showing as installed (#31514) test: fix messaging flaky test (#31512) fix: change the push sound sent when the push is from video conference (#30910) fix: ensure sessionId on Sessions documents (#31487) chore: handle rocket.cat creation and deletion (#31170) chore(agenda): Changes in Agenda API (#31427) refactor: Pay the debt of some TODO comments (#30338) feat: Room header keyboard navigability (#31516) fix: Cron job for clearing OEmbed cache isn't working (#31336) refactor(client): Handling of custom statuses (#31500) fix: Prevent `Fallback forward departments` feature to go on loop when configured as circular chain (#31328) feat: Add `push.test` endpoint (#31289) chore: split UserProvider into two: User and Authentication (#31513) fix: Can't remove channel's password to join (#31507) chore: convert CAS integration code to typescript (#31492) feat: Composer keyboard navigability (#31510) fix: Render warning in Logs - (MessageType.render is deprecated. Use MessageType.message instead) (#31426) feat: Convert emoji shortname to unicode on notification emails. (#31225) chore: Normalize `ButtonGroup` (#31499) chore: improve type definitions for login service configurations (#31491) ...
Proposed changes (including videos or screenshots)
uid
in this case);data.params undefined
error when clearing OEmbed cache (eg with the "Clear" button in the settings).Issue(s)
Fixes #29434
Steps to test or reproduce
Send some messages containing links with previews, then go to Workspace > Settings > Message and check the value for the Embed Cache Expiration Days setting. A cron job to erase all OEmbed cache registries older than
Embed Cache Expiration
days should be erased from the database (there should be no document in therocketchat_oembed_cache collection
with anupdatedAt
field older than defined in the setting).The cron job runs everydat at 2:24am (this can be changed in this line for test purposes -- use it as
* * * * *
to run every minute, for example).Further comments
SUP-425