Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(i18n): Translation's lint and load #31343

Merged
merged 10 commits into from
Jan 10, 2024
Merged

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Dec 29, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Closely related to #30645

Copy link

changeset-bot bot commented Dec 29, 2023

⚠️ No Changeset found

Latest commit: 977e839

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (c2e7116) 49.33% compared to head (977e839) 49.35%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31343      +/-   ##
===========================================
+ Coverage    49.33%   49.35%   +0.01%     
===========================================
  Files         3311     3306       -5     
  Lines        81337    81294      -43     
  Branches     16657    16655       -2     
===========================================
- Hits         40130    40119      -11     
+ Misses       36506    36477      -29     
+ Partials      4701     4698       -3     
Flag Coverage Δ
e2e 52.53% <48.00%> (+0.03%) ⬆️
e2e-api 40.66% <42.30%> (+<0.01%) ⬆️
unit 76.55% <50.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan force-pushed the refactor/i18n-scripts branch from 82aa840 to bdd7ff1 Compare January 2, 2024 22:58
@tassoevan tassoevan added this to the 6.6 milestone Jan 2, 2024
@tassoevan tassoevan marked this pull request as ready for review January 2, 2024 23:56
@tassoevan tassoevan requested review from a team as code owners January 2, 2024 23:56
@ggazzo ggazzo merged commit eecf782 into develop Jan 10, 2024
44 checks passed
@ggazzo ggazzo deleted the refactor/i18n-scripts branch January 10, 2024 19:19
gabriellsh added a commit that referenced this pull request Jan 10, 2024
…ve/Notifications

* 'develop' of github.com:RocketChat/Rocket.Chat:
  refactor(i18n): Translation's lint and load (#31343)
  fix: multiple indexes creations during migrations (#31413)
  feat: add `ImageGallery` zoom controls (#31369)
  chore: internalize flow-router (from meteor 3 branch) (#31365)
  chore: internalize meteor run as user (from meteor 3) (#31370)
  chore: internalize meteor inject initial (from meteor 3) (#31367)
  chore: internalize meteor cookies (from meteor 3) (#31366)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants