Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't show join default channels option for edit user form #31750

Merged
merged 11 commits into from
May 21, 2024

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Feb 14, 2024

Proposed changes (including videos or screenshots)

When we create new users, we have to option to add these new users to default channels.
We were also showing this option on edit users panel, which doesn't make any sense, so this PR removes this option.

Issue(s)

Steps to test or reproduce

Further comments

SUP-423

Copy link

changeset-bot bot commented Feb 14, 2024

🦋 Changeset detected

Latest commit: 11125b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/rest-typings Patch
@rocket.chat/meteor Patch
@rocket.chat/core-services Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/core-typings Patch
@rocket.chat/apps Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.17%. Comparing base (760ab4b) to head (11125b2).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31750      +/-   ##
===========================================
+ Coverage    55.96%   56.17%   +0.20%     
===========================================
  Files         2431     2420      -11     
  Lines        53557    53405     -152     
  Branches     11029    11002      -27     
===========================================
+ Hits         29974    29998      +24     
+ Misses       20946    20782     -164     
+ Partials      2637     2625      -12     
Flag Coverage Δ
e2e 55.76% <100.00%> (+0.35%) ⬆️
unit 72.32% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@yash-rajpal yash-rajpal marked this pull request as ready for review February 15, 2024 12:24
@yash-rajpal yash-rajpal requested review from a team as code owners February 15, 2024 12:24
csuadev
csuadev previously approved these changes Feb 15, 2024
Gustrb
Gustrb previously approved these changes Feb 15, 2024
@scuciatto scuciatto added this to the 6.7 milestone Feb 20, 2024
@yash-rajpal yash-rajpal dismissed stale reviews from csuadev and Gustrb via 3a3397b February 20, 2024 12:09
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could add a UI test to cover this behavior. WDYT?

@scuciatto scuciatto removed this from the 6.7 milestone Feb 29, 2024
Copy link
Contributor

dionisio-bot bot commented Apr 5, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.10.0, but it targets 6.9.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@dionisio-bot dionisio-bot bot added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA tested labels Apr 10, 2024
@scuciatto scuciatto added this to the 6.8 milestone Apr 10, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 10, 2024
@scuciatto scuciatto removed this from the 6.8 milestone Apr 18, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Apr 18, 2024
@scuciatto scuciatto added this to the 6.9 milestone Apr 26, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 26, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Apr 26, 2024
@scuciatto scuciatto modified the milestones: 6.9, 6.10 May 21, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 21, 2024
@kodiakhq kodiakhq bot merged commit 07c4ca0 into develop May 21, 2024
44 of 46 checks passed
@kodiakhq kodiakhq bot deleted the fix/join-code-editing-user branch May 21, 2024 20:23
gabriellsh added a commit that referenced this pull request May 28, 2024
…retention

* 'develop' of github.com:RocketChat/Rocket.Chat: (36 commits)
  refactor: IntegrationHistory out of DB Watcher (#32502)
  fix: Message update being broadcasted without updated values (#32472)
  test: make api teams test fully independent (#31756)
  test: Fix test name (#32490)
  fix: streams being called with no logged user (#32489)
  feat: Un-encrypted messages not allowed in E2EE rooms (#32040)
  feat(UiKit): Users select (#31455)
  fix: Re-login same browser tab issues (#32479)
  chore: move all webclient code out of the COSS folders (#32273)
  chore(deps): bump thehanimo/pr-title-checker from 1.3.7 to 1.4.1 (#30619)
  fix: Don't show join default channels option for edit user form  (#31750)
  fix: CAS user merge not working (#32444)
  fix: Overriding Retention Policy not working (#32454)
  fix: `rooms.export` endpoint generates an empty export when given an invalid date (#32364)
  fix: "Allow Password Change for OAuth Users" setting is not honored in the "Forgot Password" flow (#32398)
  fix: Bypass trash when removing OTR system messages and read receipts (#32269)
  fix: Monitors dissapearing from Unit upon edit (#32393)
  fix: Link image preview not opening in gallery (#32391)
  feat: Allow visitors & integrations to access downloaded files after a room has closed (#32439)
  regression: Users tab misaligned (#32451)
  ...
This was referenced Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants