-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Un-encrypted messages not allowed in E2EE rooms #32040
Conversation
🦋 Changeset detectedLatest commit: eb685e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32040 +/- ##
===========================================
+ Coverage 56.23% 56.27% +0.03%
===========================================
Files 2428 2434 +6
Lines 53560 53681 +121
Branches 11031 11045 +14
===========================================
+ Hits 30122 30211 +89
- Misses 20799 20832 +33
+ Partials 2639 2638 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could improve a little bit the e2ee state hooks. I'm mostly thinking about not having both useE2EERoomState and useIsE2EEReady.
Also since e2e is base on emitters, we could also have a function that returns the subscribe
and get
functions to use with useSyncExternalStore.
Maybe let's have a chat sometime about all the E2EE feature/code?
aa81aab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Back-end LGTM
…retention * 'develop' of github.com:RocketChat/Rocket.Chat: (36 commits) refactor: IntegrationHistory out of DB Watcher (#32502) fix: Message update being broadcasted without updated values (#32472) test: make api teams test fully independent (#31756) test: Fix test name (#32490) fix: streams being called with no logged user (#32489) feat: Un-encrypted messages not allowed in E2EE rooms (#32040) feat(UiKit): Users select (#31455) fix: Re-login same browser tab issues (#32479) chore: move all webclient code out of the COSS folders (#32273) chore(deps): bump thehanimo/pr-title-checker from 1.3.7 to 1.4.1 (#30619) fix: Don't show join default channels option for edit user form (#31750) fix: CAS user merge not working (#32444) fix: Overriding Retention Policy not working (#32454) fix: `rooms.export` endpoint generates an empty export when given an invalid date (#32364) fix: "Allow Password Change for OAuth Users" setting is not honored in the "Forgot Password" flow (#32398) fix: Bypass trash when removing OTR system messages and read receipts (#32269) fix: Monitors dissapearing from Unit upon edit (#32393) fix: Link image preview not opening in gallery (#32391) feat: Allow visitors & integrations to access downloaded files after a room has closed (#32439) regression: Users tab misaligned (#32451) ...
Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com> Co-authored-by: Hugo Costa <20212776+hugocostadev@users.noreply.github.com>
Proposed changes (including videos or screenshots)
We allowed users to send un-encrypted messages in encrypted rooms if the users didn't had the E2EE setup or keys were missing.
Now we are introducing a setting which will not allow users to send un-encrypted messages in E2EE rooms. If the users don't have the E2EE setup or don't have room keys, it will show a new E2EE setup interface to users, using which users will be able to get a feedback regarding their E2EE status.
Also introduced the E2EE state to track in which state the E2EE functionality is in.
Issue(s)
Steps to test or reproduce
Further comments
E2EE-3