fix: Mark as unread not working #32939

MartinSchoeler · 2024-07-30T17:17:32Z

Proposed changes (including videos or screenshots)

Fixed issue where when you marked a room as unread and you were part of it, sometimes it would mark it as read right after

Issue(s)

Steps to test or reproduce

This seems to happen only on busier servers, you can reproduce it on open.rocket.chat if you have the room open and mark it as unread, soon after it is marked as read again

dionisio-bot · 2024-07-30T17:17:36Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

changeset-bot · 2024-07-30T17:17:36Z

🦋 Changeset detected

Latest commit: f3db577

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/models	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov · 2024-07-30T17:34:20Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.84%. Comparing base (fdde637) to head (f3db577).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #32939   +/-   ##
========================================
  Coverage    59.84%   59.84%           
========================================
  Files         2554     2554           
  Lines        63014    63011    -3     
  Branches     14129    14129           
========================================
  Hits         37711    37711           
+ Misses       22896    22893    -3     
  Partials      2407     2407

Flag	Coverage Δ
unit	`77.14% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

apps/meteor/app/message-mark-as-unread/client/actionButton.ts

apps/meteor/client/sidebar/RoomMenu.tsx

apps/meteor/client/sidebarv2/RoomMenu.tsx

apps/meteor/tests/e2e/channels-sidebar.spec.ts

apps/meteor/tests/e2e/page-objects/fragments/home-sidenav.ts

apps/meteor/tests/e2e/mark-unread.spec.ts

dougfabris

ggazzo · 2024-09-03T19:30:07Z

Fixed issue where when you marked a room as read

UNread right?

github-actions · 2024-09-17T14:17:13Z

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-18 15:21 UTC

Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com>

…hAvatarById * 'develop' of github.com:RocketChat/Rocket.Chat: feat: Implement proper accessbility for report user modal (#33294) chore: update E2EE setting text (#33226) fix: conference calls are shown as "not answered" after they end (#33179) fix: markdown inconsistency with bold and italics (#33157) feat: E2EE messages mentions (#32510) refactor: Reactions set/unset (#32994) ci: auto candidate releases (#33325) feat: `RoomSidepanel` (#33225) feat: contextualbar based on chat size (#33321) fix: error on sendmessage stub (#33317) fix: `LivechatSessionTaken` webhook event called without `agent` param (#33209) refactor: Remove old `setreaction` callbacks and use new after/before callbacks (#33309) fix: Mark as unread not working (#32939) fix: Local avatars prioritized over external avatar provider and remove remnant references on client of `Accounts_AvatarExternalProviderUrl` (#33296) feat: Allow managing association to business units on departments' creation and update (#32682)

* Bump 6.12.1 * fix: message parser being slow to process very long messages with too many symbols (#33254) Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com> * fix: Allow to use the token from `room.v` when requesting transcript instead of finding visitor (#33242) Co-authored-by: Kevin Aleman <11577696+KevLehman@users.noreply.github.com> * fix: Retention Policy cached settings not updated during upgrade procedure (#33265) Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com> * fix: imported fixes (#33268) Co-authored-by: Julio A. <52619625+julio-cfa@users.noreply.github.com> * Release 6.12.1 [no ci] * fix: Federation callback not awaiting model call (#33298) * fix: correct parameter order in afterSaveMessage to restore outgoing webhooks and related features (#33295) * feat: New endpoint for listing rooms & discussions from teams (#33177) * chore: Update typings on callbacks to accept less than a full room object (#33305) * fix: resolve avatar download issue on setUsername by refining service selection logic (#33193) * feat: Allow managing association to business units on departments' creation and update (#32682) * fix: Local avatars prioritized over external avatar provider and remove remnant references on client of `Accounts_AvatarExternalProviderUrl` (#33296) Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com> * fix: Mark as unread not working (#32939) Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com> * refactor: Remove old `setreaction` callbacks and use new after/before callbacks (#33309) * fix: `LivechatSessionTaken` webhook event called without `agent` param (#33209) * fix: error on sendmessage stub (#33317) * feat: contextualbar based on chat size (#33321) * feat: `RoomSidepanel` (#33225) Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com> * ci: auto candidate releases (#33325) Co-authored-by: Diego Sampaio <chinello@gmail.com> * refactor: Reactions set/unset (#32994) * feat: E2EE messages mentions (#32510) * fix: markdown inconsistency with bold and italics (#33157) * fix: conference calls are shown as "not answered" after they end (#33179) * Release 6.13.0-rc.0 * chore: update E2EE setting text (#33226) * feat: Implement proper accessbility for report user modal (#33294) Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com> * fix: imported fixes (#33330) * chore: create network broker package (#33338) * feat: Adds new admin feature preview setting management (#33212) Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> * chore: move common files to core-services (#33341) * regression: `Sidepanel` color highlight (#33342) * feat: Adds new admin feature preview setting management (#33212) Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> * fix: Avoid destructuring `connectionData` when value is undefined (#33339) * Release 6.13.0-rc.1 [no ci] * chore: replace Meteor._localStorage -> Accounts.storageLocation (#33356) * Bump rocket.chat to 6.14.0-develop (#33366) * ci: use node20 for release action (#33343) --------- Co-authored-by: rocketchat-github-ci <buildmaster@rocket.chat> Co-authored-by: dionisio-bot[bot] <117394943+dionisio-bot[bot]@users.noreply.github.com> Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com> Co-authored-by: Kevin Aleman <11577696+KevLehman@users.noreply.github.com> Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com> Co-authored-by: Julio A. <52619625+julio-cfa@users.noreply.github.com> Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> Co-authored-by: Kevin Aleman <kaleman960@gmail.com> Co-authored-by: Ricardo Garim <rswarovsky@gmail.com> Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com> Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat> Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat> Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com> Co-authored-by: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com> Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com> Co-authored-by: Diego Sampaio <chinello@gmail.com> Co-authored-by: Hugo Costa <hugocarreiracosta@gmail.com> Co-authored-by: csuadev <72958726+csuadev@users.noreply.github.com> Co-authored-by: Henrique Guimarães Ribeiro <43561537+rique223@users.noreply.github.com> Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com> Co-authored-by: Lucas Pelegrino <lucas.pelegrino@icloud.com> Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>

Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com>

fix: Mark as unread not working

ec9e093

Create hot-balloons-travel.md

f8c672f

MartinSchoeler added this to the 6.12 milestone Jul 30, 2024

MartinSchoeler added 3 commits July 31, 2024 17:10

test: Mark as unread not working

e1edd84

Fix order

1500314

Merge branch 'develop' into fix/mark-unread

3022a8d

MartinSchoeler marked this pull request as ready for review August 1, 2024 17:42

MartinSchoeler requested a review from a team as a code owner August 1, 2024 17:42

MarcosSpessatto requested changes Aug 2, 2024

View reviewed changes

MartinSchoeler added 5 commits August 2, 2024 15:00

revert package removal

39655aa

revert rerouting

6036d88

more tests

d974788

Update hot-balloons-travel.md

68b55c3

Update mark-unread.spec.ts

44f6da6

MartinSchoeler mentioned this pull request Aug 2, 2024

fix: Mark as unread redirecting even if you don't have the channel open #32971

Draft

dougfabris requested changes Aug 5, 2024

View reviewed changes

apps/meteor/tests/e2e/page-objects/fragments/home-sidenav.ts Outdated Show resolved Hide resolved

apps/meteor/tests/e2e/mark-unread.spec.ts Outdated Show resolved Hide resolved

apps/meteor/tests/e2e/mark-unread.spec.ts Outdated Show resolved Hide resolved

MartinSchoeler added 5 commits August 5, 2024 14:44

reviews

617d0aa

Merge branch 'develop' into fix/mark-unread

612f9a7

Merge branch 'develop' into fix/mark-unread

83aa653

Merge branch 'develop' into fix/mark-unread

5b2a504

Merge branch 'develop' into fix/mark-unread

3b73135

scuciatto removed this from the 6.12 milestone Aug 20, 2024

MartinSchoeler added 4 commits August 29, 2024 16:28

invalidate sidebar query

088c967

test

2821609

reveiew

6450e28

Merge branch 'develop' into fix/mark-unread

ab63c92

MarcosSpessatto previously approved these changes Sep 2, 2024

View reviewed changes

dougfabris previously approved these changes Sep 3, 2024

View reviewed changes

fix: [gazzo: Gazzo]

e406ac6

MartinSchoeler dismissed dougfabris’s stale review via e406ac6 September 3, 2024 19:03

Update hot-balloons-travel.md

f07fcc5

dougfabris previously approved these changes Sep 3, 2024

View reviewed changes

MarcosSpessatto previously approved these changes Sep 4, 2024

View reviewed changes

ggazzo previously approved these changes Sep 4, 2024

View reviewed changes

jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Sep 16, 2024

dionisio-bot bot added the stat: conflict label Sep 16, 2024

Merge remote-tracking branch 'origin/develop' into fix/mark-unread

4a44af7

MartinSchoeler dismissed stale reviews from ggazzo, MarcosSpessatto, and dougfabris via 4a44af7 September 17, 2024 14:15

dionisio-bot bot removed the stat: conflict label Sep 17, 2024

tiagoevanp approved these changes Sep 17, 2024

View reviewed changes

Merge branch 'develop' into fix/mark-unread

728ddff

scuciatto added the stat: ready to merge PR tested and approved waiting for merge label Sep 18, 2024

Merge branch 'develop' into fix/mark-unread

a0a1cbb

MarcosSpessatto approved these changes Sep 18, 2024

View reviewed changes

kodiakhq bot added 2 commits September 18, 2024 14:10

Merge branch 'develop' into fix/mark-unread

c74d20b

Merge branch 'develop' into fix/mark-unread

f3db577

kodiakhq bot merged commit ba8bee4 into develop Sep 18, 2024
50 checks passed

kodiakhq bot deleted the fix/mark-unread branch September 18, 2024 15:21

rocketchat-github-ci mentioned this pull request Sep 20, 2024

Release 6.13.0 #33326

Merged

KevLehman pushed a commit that referenced this pull request Sep 20, 2024

fix: Mark as unread not working (#32939)

51c8c73

Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com>

abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024

fix: Mark as unread not working (#32939)

50b1cb0

Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Mark as unread not working #32939

fix: Mark as unread not working #32939

MartinSchoeler commented Jul 30, 2024 •

edited

Loading

dionisio-bot bot commented Jul 30, 2024 •

edited

Loading

changeset-bot bot commented Jul 30, 2024 •

edited

Loading

codecov bot commented Jul 30, 2024 •

edited

Loading

dougfabris left a comment

ggazzo commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 17, 2024 •

edited

Loading

fix: Mark as unread not working #32939

fix: Mark as unread not working #32939

Conversation

MartinSchoeler commented Jul 30, 2024 • edited Loading

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

dionisio-bot bot commented Jul 30, 2024 • edited Loading

changeset-bot bot commented Jul 30, 2024 • edited Loading

🦋 Changeset detected

codecov bot commented Jul 30, 2024 • edited Loading

Codecov Report

dougfabris left a comment

Choose a reason for hiding this comment

ggazzo commented Sep 3, 2024 • edited Loading

github-actions bot commented Sep 17, 2024 • edited Loading

MartinSchoeler commented Jul 30, 2024 •

edited

Loading

dionisio-bot bot commented Jul 30, 2024 •

edited

Loading

changeset-bot bot commented Jul 30, 2024 •

edited

Loading

codecov bot commented Jul 30, 2024 •

edited

Loading

ggazzo commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 17, 2024 •

edited

Loading