fix: Avoid destructuring `connectionData` when value is undefined #33339

KevLehman · 2024-09-23T20:10:12Z

Proposed changes (including videos or screenshots)

Issue(s)

SUP-672

Steps to test or reproduce

Further comments

#32620 introduced the bug, mainly for apps engine, which caused that when GDPR setting is enabled, new visitors cannot be created. This is because the server was trying to destructure connectionData, which was undefined.

The code on LivechatTyped was edited in a way that it was not checking connectionData to be an object before destructuring, causing the visitor creation to error out before completion.

…ined

dionisio-bot · 2024-09-23T20:10:16Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

changeset-bot · 2024-09-23T20:10:17Z

🦋 Changeset detected

Latest commit: aa0cc52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-09-23T20:16:12Z

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33339/
on branch `gh-pages` at 2024-09-24 18:07 UTC

codecov · 2024-09-23T20:35:47Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.85%. Comparing base (1d29a74) to head (aa0cc52).
Report is 1 commits behind head on release-6.13.0.

Additional details and impacted files

@@               Coverage Diff               @@
##           release-6.13.0   #33339   +/-   ##
===============================================
  Coverage           58.85%   58.85%           
===============================================
  Files                2692     2692           
  Lines               65281    65281           
  Branches            14727    14727           
===============================================
  Hits                38424    38424           
  Misses              24387    24387           
  Partials             2470     2470

Flag	Coverage Δ
unit	`77.19% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

.changeset/brave-brooms-invent.md

Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com>

stale

scuciatto · 2024-09-24T19:56:56Z

/patch

…3339)

dionisio-bot · 2024-09-24T19:57:33Z

Pull request #33348 added to Project: "Patch 6.12.2"

scuciatto · 2024-09-24T21:33:31Z

/backport 6.11.4

…3339)

dionisio-bot · 2024-09-24T21:34:08Z

Pull request #33350 added to Project: "undefined"

* Bump 6.12.1 * fix: message parser being slow to process very long messages with too many symbols (#33254) Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com> * fix: Allow to use the token from `room.v` when requesting transcript instead of finding visitor (#33242) Co-authored-by: Kevin Aleman <11577696+KevLehman@users.noreply.github.com> * fix: Retention Policy cached settings not updated during upgrade procedure (#33265) Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com> * fix: imported fixes (#33268) Co-authored-by: Julio A. <52619625+julio-cfa@users.noreply.github.com> * Release 6.12.1 [no ci] * fix: Federation callback not awaiting model call (#33298) * fix: correct parameter order in afterSaveMessage to restore outgoing webhooks and related features (#33295) * feat: New endpoint for listing rooms & discussions from teams (#33177) * chore: Update typings on callbacks to accept less than a full room object (#33305) * fix: resolve avatar download issue on setUsername by refining service selection logic (#33193) * feat: Allow managing association to business units on departments' creation and update (#32682) * fix: Local avatars prioritized over external avatar provider and remove remnant references on client of `Accounts_AvatarExternalProviderUrl` (#33296) Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com> * fix: Mark as unread not working (#32939) Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com> * refactor: Remove old `setreaction` callbacks and use new after/before callbacks (#33309) * fix: `LivechatSessionTaken` webhook event called without `agent` param (#33209) * fix: error on sendmessage stub (#33317) * feat: contextualbar based on chat size (#33321) * feat: `RoomSidepanel` (#33225) Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com> * ci: auto candidate releases (#33325) Co-authored-by: Diego Sampaio <chinello@gmail.com> * refactor: Reactions set/unset (#32994) * feat: E2EE messages mentions (#32510) * fix: markdown inconsistency with bold and italics (#33157) * fix: conference calls are shown as "not answered" after they end (#33179) * Release 6.13.0-rc.0 * chore: update E2EE setting text (#33226) * feat: Implement proper accessbility for report user modal (#33294) Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com> * fix: imported fixes (#33330) * chore: create network broker package (#33338) * feat: Adds new admin feature preview setting management (#33212) Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> * chore: move common files to core-services (#33341) * regression: `Sidepanel` color highlight (#33342) * feat: Adds new admin feature preview setting management (#33212) Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> * fix: Avoid destructuring `connectionData` when value is undefined (#33339) * Release 6.13.0-rc.1 [no ci] * chore: replace Meteor._localStorage -> Accounts.storageLocation (#33356) * Bump rocket.chat to 6.14.0-develop (#33366) * ci: use node20 for release action (#33343) --------- Co-authored-by: rocketchat-github-ci <buildmaster@rocket.chat> Co-authored-by: dionisio-bot[bot] <117394943+dionisio-bot[bot]@users.noreply.github.com> Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com> Co-authored-by: Kevin Aleman <11577696+KevLehman@users.noreply.github.com> Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com> Co-authored-by: Julio A. <52619625+julio-cfa@users.noreply.github.com> Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> Co-authored-by: Kevin Aleman <kaleman960@gmail.com> Co-authored-by: Ricardo Garim <rswarovsky@gmail.com> Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com> Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat> Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat> Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com> Co-authored-by: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com> Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com> Co-authored-by: Diego Sampaio <chinello@gmail.com> Co-authored-by: Hugo Costa <hugocarreiracosta@gmail.com> Co-authored-by: csuadev <72958726+csuadev@users.noreply.github.com> Co-authored-by: Henrique Guimarães Ribeiro <43561537+rique223@users.noreply.github.com> Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com> Co-authored-by: Lucas Pelegrino <lucas.pelegrino@icloud.com> Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>

…apped/composer-restriction * 'develop' of github.com:RocketChat/Rocket.Chat: (55 commits) regression: `Sidepanel` sort requires refresh after room update (#33370) ci: use node20 for release action (#33343) Bump rocket.chat to 6.14.0-develop (#33366) chore: replace Meteor._localStorage -> Accounts.storageLocation (#33356) Release 6.13.0-rc.1 fix: Avoid destructuring `connectionData` when value is undefined (#33339) feat: Adds new admin feature preview setting management (#33212) regression: `Sidepanel` color highlight (#33342) chore: move common files to core-services (#33341) feat: Adds new admin feature preview setting management (#33212) chore: create network broker package (#33338) fix: imported fixes (#33330) feat: Implement proper accessbility for report user modal (#33294) chore: update E2EE setting text (#33226) Release 6.13.0-rc.0 fix: conference calls are shown as "not answered" after they end (#33179) fix: markdown inconsistency with bold and italics (#33157) feat: E2EE messages mentions (#32510) refactor: Reactions set/unset (#32994) ci: auto candidate releases (#33325) ...

…ocket.Chat into feat/airgapped-restrictions * 'feat/airgapped-restrictions' of github.com:RocketChat/Rocket.Chat: (57 commits) fix: Async E2EE key exchange not working on develop (#33378) chore: Move Apps-Engine to monorepo (#32951) chore(Sidepanel): uses only local channels and discussions (#33387) chore: add gazzodown preview (#33279) fix: Avoid notifying `watch.settings` on uncaught errors (#33376) fix: race condition when forwarding livechat by splitting subscription removal (#33381) chore: Single Contact ID: improved typings and removed some duplicated code (#33324) ci: remove Jira-GitHub security integration (#33384) chore: add ui-composer to storybook (#33383) regression: `Sidepanel` sort requires refresh after room update (#33370) ci: use node20 for release action (#33343) Bump rocket.chat to 6.14.0-develop (#33366) chore: replace Meteor._localStorage -> Accounts.storageLocation (#33356) Release 6.13.0-rc.1 fix: Avoid destructuring `connectionData` when value is undefined (#33339) feat: Adds new admin feature preview setting management (#33212) regression: `Sidepanel` color highlight (#33342) chore: move common files to core-services (#33341) feat: Adds new admin feature preview setting management (#33212) chore: create network broker package (#33338) ...

…3339)

Fix invalid connectionData destructuring when connectionData is undef…

918dfed

…ined

Create brave-brooms-invent.md

7f3c6f1

KevLehman added this to the 6.13 milestone Sep 24, 2024

KevLehman marked this pull request as ready for review September 24, 2024 12:04

KevLehman requested review from a team as code owners September 24, 2024 12:04

ricardogarim previously approved these changes Sep 24, 2024

View reviewed changes

matheusbsilva137 previously requested changes Sep 24, 2024

View reviewed changes

.changeset/brave-brooms-invent.md Outdated Show resolved Hide resolved

Update .changeset/brave-brooms-invent.md

789455d

Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com>

KevLehman dismissed ricardogarim’s stale review via 789455d September 24, 2024 15:49

KevLehman requested review from matheusbsilva137 and ricardogarim September 24, 2024 15:50

ricardogarim approved these changes Sep 24, 2024

View reviewed changes

aleksandernsilva approved these changes Sep 24, 2024

View reviewed changes

KevLehman added the stat: QA tested label Sep 24, 2024

dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA tested labels Sep 24, 2024

KevLehman added stat: QA tested and removed stat: QA assured Means it has been tested and approved by a company insider labels Sep 24, 2024

KevLehman removed the stat: QA tested label Sep 24, 2024

dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Sep 24, 2024

KevLehman added stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider labels Sep 24, 2024

Merge branch 'release-6.13.0' into fix/gdpr-connection-data-misbehaving

aa0cc52

kodiakhq bot merged commit 519ed86 into release-6.13.0 Sep 24, 2024
9 of 10 checks passed

kodiakhq bot deleted the fix/gdpr-connection-data-misbehaving branch September 24, 2024 18:03

rocketchat-github-ci mentioned this pull request Sep 24, 2024

Release 6.13.0 #33326

Merged

dionisio-bot bot pushed a commit that referenced this pull request Sep 24, 2024

fix: Avoid destructuring connectionData when value is undefined (#3…

889c0bb

…3339)

dionisio-bot bot mentioned this pull request Sep 24, 2024

fix: Avoid destructuring connectionData when value is undefined #33348

Merged

dionisio-bot bot pushed a commit that referenced this pull request Sep 24, 2024

fix: Avoid destructuring connectionData when value is undefined (#3…

ab6634e

…3339)

dionisio-bot bot mentioned this pull request Sep 24, 2024

fix: Avoid destructuring connectionData when value is undefined #33350

Merged

abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024

fix: Avoid destructuring connectionData when value is undefined (#3…

60e64c5

…3339)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Avoid destructuring `connectionData` when value is undefined #33339

fix: Avoid destructuring `connectionData` when value is undefined #33339

KevLehman commented Sep 23, 2024 •

edited

Loading

dionisio-bot bot commented Sep 23, 2024 •

edited

Loading

changeset-bot bot commented Sep 23, 2024 •

edited

Loading

github-actions bot commented Sep 23, 2024 •

edited

Loading

codecov bot commented Sep 23, 2024 •

edited

Loading

scuciatto commented Sep 24, 2024

dionisio-bot bot commented Sep 24, 2024

scuciatto commented Sep 24, 2024

dionisio-bot bot commented Sep 24, 2024

fix: Avoid destructuring connectionData when value is undefined #33339

fix: Avoid destructuring connectionData when value is undefined #33339

Conversation

KevLehman commented Sep 23, 2024 • edited Loading

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

dionisio-bot bot commented Sep 23, 2024 • edited Loading

changeset-bot bot commented Sep 23, 2024 • edited Loading

🦋 Changeset detected

github-actions bot commented Sep 23, 2024 • edited Loading

codecov bot commented Sep 23, 2024 • edited Loading

Codecov Report

scuciatto commented Sep 24, 2024

dionisio-bot bot commented Sep 24, 2024

scuciatto commented Sep 24, 2024

dionisio-bot bot commented Sep 24, 2024

fix: Avoid destructuring `connectionData` when value is undefined #33339

fix: Avoid destructuring `connectionData` when value is undefined #33339

KevLehman commented Sep 23, 2024 •

edited

Loading

dionisio-bot bot commented Sep 23, 2024 •

edited

Loading

changeset-bot bot commented Sep 23, 2024 •

edited

Loading

github-actions bot commented Sep 23, 2024 •

edited

Loading

codecov bot commented Sep 23, 2024 •

edited

Loading