Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid processRoomAbandonment callback from erroring when Business Hours config is missing for day #33058

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Aug 14, 2024

Proposed changes (including videos or screenshots)

  • When a room was closed and this room was inactive for many days and one of those days happened to not be on the Business Hours configuration (either single or multiple) callback throwed an error when attempting to calculate the time. Now, it will correctly skip these days.
  • Tests are in a companion PR, that won't be patched.

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-611

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Aug 14, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 14, 2024

🦋 Changeset detected

Latest commit: d3ce45d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@KevLehman KevLehman changed the title avoid callback from erroring when bh config is changed fix: Avoid processRoomAbandonment callback from erroring when Business Hours config is missing for day Aug 14, 2024
@KevLehman KevLehman marked this pull request as ready for review August 14, 2024 20:13
@KevLehman KevLehman requested a review from a team as a code owner August 14, 2024 20:13
@KevLehman KevLehman added this to the 6.12 milestone Aug 14, 2024
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Aug 16, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.40%. Comparing base (c8dac9f) to head (d3ce45d).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33058   +/-   ##
========================================
  Coverage    59.40%   59.40%           
========================================
  Files         2541     2541           
  Lines        63176    63176           
  Branches     14220    14220           
========================================
  Hits         37527    37527           
  Misses       22934    22934           
  Partials      2715     2715           
Flag Coverage Δ
unit 76.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit 683b55b into develop Aug 16, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the patch/process-roomabandonment-cb branch August 16, 2024 18:03
@scuciatto
Copy link
Member

/patch

Copy link
Contributor

dionisio-bot bot commented Aug 19, 2024

Pull request #33084 added to Project: "undefined"

@scuciatto
Copy link
Member

/backport 6.10.5

Copy link
Contributor

dionisio-bot bot commented Aug 19, 2024

Pull request #33085 added to Project: "undefined"

abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants