Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid processRoomAbandonment callback from erroring when Business Hours config is missing for day #33084

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Aug 19, 2024

Backport of #33058

@dionisio-bot dionisio-bot bot requested a review from a team as a code owner August 19, 2024 14:06
@dionisio-bot dionisio-bot bot requested a review from KevLehman August 19, 2024 14:06
Copy link

changeset-bot bot commented Aug 19, 2024

🦋 Changeset detected

Latest commit: bd99288

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot dionisio-bot bot added this to the 6.11 milestone Aug 19, 2024
Copy link
Contributor Author

dionisio-bot bot commented Aug 19, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.65%. Comparing base (6bcbc02) to head (bd99288).
Report is 1 commits behind head on release-6.11.2.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-6.11.2   #33084      +/-   ##
==================================================
+ Coverage           55.63%   55.65%   +0.02%     
==================================================
  Files                2636     2634       -2     
  Lines               57507    57626     +119     
  Branches            11934    11985      +51     
==================================================
+ Hits                31992    32074      +82     
- Misses              22793    22826      +33     
- Partials             2722     2726       +4     
Flag Coverage Δ
e2e 54.32% <ø> (+<0.01%) ⬆️
e2e-api 41.24% <ø> (+0.07%) ⬆️
unit 71.85% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Aug 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 19, 2024
@KevLehman KevLehman added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Aug 19, 2024
@kodiakhq kodiakhq bot merged commit 9e1b9ad into release-6.11.2 Aug 19, 2024
61 checks passed
@kodiakhq kodiakhq bot deleted the backport-6.11.2-33058 branch August 19, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants