regression: Handle live setting forget user session on window close update

[yash-rajpal]

Proposed changes (including videos or screenshots)

Meteor recently developed a way to choose the client storage location between local storage and session storage.

We recently started configuring meteor to choose between both location options based on our setting Accounts_ForgetUserSessionOnWindowClose.

There was a small issue, we are handling these updates in a Tracker.autorun which runs everytime any dependency changes. In this case, it wasn't handling this setting change on a live user session.

We shouldn't change the client storage location in the middle of an active session, so this PR fixes it by stopping the autorun and which stops the listening of live setting update, essentially just configuring the client storage location just once in a session.

Issue(s)

Steps to test or reproduce

Further comments

CORE-653

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: d050713

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.38%. Comparing base (10baefd) to head (d050713).
Report is 18 commits behind head on release-6.12.0.

Additional details and impacted files

@@                Coverage Diff                 @@
##           release-6.12.0   #33133      +/-   ##
==================================================
- Coverage           59.39%   59.38%   -0.01%     
==================================================
  Files                2547     2547              
  Lines               63241    63242       +1     
  Branches            14223    14225       +2     
==================================================
  Hits                37559    37559              
- Misses              22974    22975       +1     
  Partials             2708     2708              

Flag	Coverage Δ
unit	75.84% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[scuciatto]

/backport 6.10.5

[dionisio-bot]

Pull request #33150 added to Project: "Patch 6.10.5"

[scuciatto]

/patch

[matheusbsilva137]

/patch

[ggazzo]

/patch

[ggazzo]

/patch

[dionisio-bot]

Pull request #33165 added to Project: "Patch 6.11.2"