Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Handle live setting forget user session on window close update #33165

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Aug 27, 2024

Backport of #33133

@dionisio-bot dionisio-bot bot requested a review from a team as a code owner August 27, 2024 17:21
@dionisio-bot dionisio-bot bot requested a review from yash-rajpal August 27, 2024 17:21
@dionisio-bot dionisio-bot bot added this to the 6.11 milestone Aug 27, 2024
Copy link

changeset-bot bot commented Aug 27, 2024

⚠️ No Changeset found

Latest commit: 5f4537d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

dionisio-bot bot commented Aug 27, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.64%. Comparing base (aa39197) to head (5f4537d).
Report is 1 commits behind head on release-6.11.2.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-6.11.2   #33165      +/-   ##
==================================================
+ Coverage           55.61%   55.64%   +0.02%     
==================================================
  Files                2637     2637              
  Lines               57525    57526       +1     
  Branches            11939    11939              
==================================================
+ Hits                31992    32009      +17     
+ Misses              22807    22795      -12     
+ Partials             2726     2722       -4     
Flag Coverage Δ
e2e 54.32% <100.00%> (+0.05%) ⬆️
unit 71.88% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Aug 27, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 27, 2024
@kodiakhq kodiakhq bot merged commit 4baf1e4 into release-6.11.2 Aug 27, 2024
53 of 54 checks passed
@kodiakhq kodiakhq bot deleted the backport-6.11.2-33133 branch August 27, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants