Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Login services button colors #33333

Merged
merged 5 commits into from
Oct 18, 2024
Merged

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Sep 23, 2024

Proposed changes (including videos or screenshots)

The login services button was not implementing the button color properties, so fixed it and now the login services button will render the button colors as per the settings.

Also added the alerts for all button-color settings.

Implemented a migration for existing workspaces, to update all the button and label colors setting values according to our design system.

image

image

Issue(s)

Steps to test or reproduce

Further comments

SUP-590

Copy link
Contributor

dionisio-bot bot commented Sep 23, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Sep 23, 2024

🦋 Changeset detected

Latest commit: 9305946

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/web-ui-registration Major
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 23, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33333/
on branch gh-pages at 2024-10-17 13:12 UTC

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.81%. Comparing base (4e1f8ef) to head (eb70568).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33333   +/-   ##
========================================
  Coverage    74.81%   74.81%           
========================================
  Files          469      469           
  Lines        20687    20687           
  Branches      5278     5278           
========================================
  Hits         15477    15477           
  Misses        4595     4595           
  Partials       615      615           
Flag Coverage Δ
unit 74.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo force-pushed the release-7.0.0 branch 4 times, most recently from 50abbe6 to bf02ce5 Compare September 27, 2024 22:43
@sampaiodiego sampaiodiego force-pushed the release-7.0.0 branch 2 times, most recently from d1aa5f9 to 374979f Compare October 9, 2024 17:43
@ggazzo ggazzo force-pushed the release-7.0.0 branch 6 times, most recently from 09c1b34 to 3099c34 Compare October 11, 2024 21:14
@yash-rajpal yash-rajpal force-pushed the fix/login-services-button-props branch from a303afd to a6df2c5 Compare October 14, 2024 12:16
@yash-rajpal yash-rajpal changed the base branch from release-7.0.0 to develop October 14, 2024 12:19
@yash-rajpal yash-rajpal changed the base branch from develop to release-7.0.0 October 14, 2024 12:19
@ggazzo ggazzo force-pushed the fix/login-services-button-props branch from 83a5c1e to 1cd9df2 Compare October 14, 2024 15:06
@yash-rajpal yash-rajpal marked this pull request as ready for review October 14, 2024 20:24
@yash-rajpal yash-rajpal requested review from a team as code owners October 14, 2024 20:24
@ggazzo ggazzo requested review from a team as code owners October 15, 2024 00:45
@yash-rajpal yash-rajpal force-pushed the fix/login-services-button-props branch from ce4bc2d to 324649f Compare October 15, 2024 12:51
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please write a description for the PR

.changeset/fifty-mails-admire.md Outdated Show resolved Hide resolved
apps/meteor/server/startup/migrations/v313.ts Outdated Show resolved Hide resolved
apps/meteor/tests/e2e/utils/convertHexToRGB.ts Outdated Show resolved Hide resolved
@MarcosSpessatto MarcosSpessatto changed the title fix: Login services button colors fix!: Login services button colors Oct 15, 2024
@yash-rajpal yash-rajpal force-pushed the fix/login-services-button-props branch from c14a3a3 to de61ae4 Compare October 15, 2024 18:40
@yash-rajpal yash-rajpal requested review from a team and removed request for a team October 16, 2024 13:58
@yash-rajpal yash-rajpal added this to the 7.0 milestone Oct 16, 2024
@ggazzo ggazzo force-pushed the fix/login-services-button-props branch from de61ae4 to 17d9ed1 Compare October 16, 2024 21:28
@ggazzo ggazzo force-pushed the release-7.0.0 branch 3 times, most recently from 08d4324 to 57dd899 Compare October 17, 2024 03:35
Base automatically changed from release-7.0.0 to develop October 17, 2024 04:28
An error occurred while trying to automatically change base from release-7.0.0 to develop October 17, 2024 04:28
@ggazzo ggazzo force-pushed the fix/login-services-button-props branch from 17d9ed1 to eb70568 Compare October 17, 2024 13:03
@ggazzo
Copy link
Member

ggazzo commented Oct 18, 2024

merging before conflicts again

@ggazzo ggazzo merged commit d44f614 into develop Oct 18, 2024
5 of 7 checks passed
@ggazzo ggazzo deleted the fix/login-services-button-props branch October 18, 2024 02:48
This was referenced Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants