-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: Login services button colors #33333
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 9305946 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33333 +/- ##
========================================
Coverage 74.81% 74.81%
========================================
Files 469 469
Lines 20687 20687
Branches 5278 5278
========================================
Hits 15477 15477
Misses 4595 4595
Partials 615 615
Flags with carried forward coverage won't be shown. Click here to find out more. |
50abbe6
to
bf02ce5
Compare
d1aa5f9
to
374979f
Compare
09c1b34
to
3099c34
Compare
a303afd
to
a6df2c5
Compare
83a5c1e
to
1cd9df2
Compare
ce4bc2d
to
324649f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please write a description for the PR
c14a3a3
to
de61ae4
Compare
de61ae4
to
17d9ed1
Compare
08d4324
to
57dd899
Compare
17d9ed1
to
eb70568
Compare
eb70568
to
9305946
Compare
merging before conflicts again |
Proposed changes (including videos or screenshots)
The login services button was not implementing the button color properties, so fixed it and now the login services button will render the button colors as per the settings.
Also added the alerts for all button-color settings.
Implemented a migration for existing workspaces, to update all the button and label colors setting values according to our design system.
Issue(s)
Steps to test or reproduce
Further comments
SUP-590