Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert #31102 #33612

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

yash-rajpal
Copy link
Member

Reverts #31102

We have a new PR #33333 which implements these button colors and we need these settings.

#31102 removes these settings which are now required, so this PR reverts #31102

Copy link
Contributor

dionisio-bot bot commented Oct 16, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 16, 2024

⚠️ No Changeset found

Latest commit: df9392a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yash-rajpal yash-rajpal changed the title Revert #31102 chore: Revert #31102 Oct 16, 2024
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33612/
on branch gh-pages at 2024-10-16 19:22 UTC

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.0.0@41ca328). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-7.0.0   #33612   +/-   ##
================================================
  Coverage                 ?   74.79%           
================================================
  Files                    ?      467           
  Lines                    ?    20641           
  Branches                 ?     5262           
================================================
  Hits                     ?    15439           
  Misses                   ?     4590           
  Partials                 ?      612           
Flag Coverage Δ
unit 74.79% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@yash-rajpal yash-rajpal marked this pull request as ready for review October 16, 2024 19:36
@yash-rajpal yash-rajpal requested review from a team as code owners October 16, 2024 19:36
@ggazzo ggazzo merged commit 7e4cb29 into release-7.0.0 Oct 16, 2024
42 of 44 checks passed
@ggazzo ggazzo deleted the revert-31102-fix/remove-unused-oauth-setting branch October 16, 2024 20:09
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
This reverts commit 9aff835.
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
This reverts commit 9aff835.
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
This reverts commit 9aff835.
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
This reverts commit 9aff835.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants