Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid destructuring connectionData when value is undefined #33350

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Sep 24, 2024

Backport of #33339

@dionisio-bot dionisio-bot bot requested review from a team as code owners September 24, 2024 21:33
@dionisio-bot dionisio-bot bot requested a review from KevLehman September 24, 2024 21:33
Copy link

changeset-bot bot commented Sep 24, 2024

🦋 Changeset detected

Latest commit: ab6634e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot dionisio-bot bot added this to the 6.11 milestone Sep 24, 2024
Copy link
Contributor Author

dionisio-bot bot commented Sep 24, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@scuciatto scuciatto added the stat: QA assured Means it has been tested and approved by a company insider label Sep 24, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 24, 2024
@kodiakhq kodiakhq bot merged commit 0b0ede7 into release-6.11.4 Sep 24, 2024
12 of 14 checks passed
@kodiakhq kodiakhq bot deleted the backport-6.11.4-33339 branch September 24, 2024 21:39
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.42%. Comparing base (536884c) to head (ab6634e).
Report is 1 commits behind head on release-6.11.4.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-6.11.4   #33350      +/-   ##
==================================================
+ Coverage           56.16%   58.42%   +2.25%     
==================================================
  Files                2637     2637              
  Lines               57523    57523              
  Branches            11941    11941              
==================================================
+ Hits                32309    33609    +1300     
+ Misses              22795    22128     -667     
+ Partials             2419     1786     -633     
Flag Coverage Δ
e2e 58.68% <ø> (+4.31%) ⬆️
unit 74.48% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants